Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix circular import problem with typing ModuleInfo #328

Open
davidorme opened this issue Oct 4, 2023 · 0 comments
Open

Fix circular import problem with typing ModuleInfo #328

davidorme opened this issue Oct 4, 2023 · 0 comments
Labels
bug Something isn't working
Milestone
Core structures

Comments

@davidorme
Copy link
Collaborator

Describe the bug
Typing the core.registry.ModuleInfo with BaseModel is what we should be doing but it causes circular imports. We need to restructure something to get properly accurate typing on the MODULE_REGISTRY components.
@davidorme davidorme added the bug Something isn't working label Oct 4, 2023
@davidorme davidorme mentioned this issue Oct 4, 2023
Merged
5 tasks
@davidorme davidorme added this to the Core structures milestone Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Core structures
Development

No branches or pull requests
1 participant
@davidorme