Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core/model.py to core/base_model.py #178

Closed
davidorme opened this issue Feb 13, 2023 · 0 comments · Fixed by #177
Closed

Update core/model.py to core/base_model.py #178

davidorme opened this issue Feb 13, 2023 · 0 comments · Fixed by #177

Comments

@davidorme
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

We've renamed the actual models (soil/model.py -> soil/soil_model.py) to make the file names all less confusing, but the BaseModel ABC still lives in core/model.py. As discussed in PR #176 , we think this is better explicitly named as core/base_model.py.

Describe the solution you'd like

  • Change the name of the file
  • Update all the doc links (probably just a search and replace of core.model to core.base_model).
@jacobcook1995 jacobcook1995 linked a pull request Feb 14, 2023 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant