Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to ROI presentation and UI support #184

Open
fedorov opened this issue Dec 14, 2023 · 11 comments
Open

Improvements to ROI presentation and UI support #184

fedorov opened this issue Dec 14, 2023 · 11 comments
Assignees
Labels
enhancement New feature or request

Comments

@fedorov
Copy link
Member

fedorov commented Dec 14, 2023

Right now, on this example, same color is applied, and it is impossible for the user to tell different kinds of ROI one from another

https://andrey-slim-test.web.app/studies/2.25.155017484756498730492136597238994838876/series/1.3.6.1.4.1.5962.99.1.3434988325.342625608.1687062201125.4.0

@fedorov fedorov added the enhancement New feature or request label Dec 14, 2023
@fedorov
Copy link
Member Author

fedorov commented Dec 15, 2023

Additional ideas related to visualization of the individual regions:

  • allow applying the same color all regions of the same semantics and allow toggling them all at the same time
  • show ROI number/details in a tooltip as an option on mouse-over

@fedorov
Copy link
Member Author

fedorov commented Jan 24, 2024

Related suggestions from Javed Khan group communicated by @curtislisle:

  • Each SR object belongs to a class (e.g. ERMS, ARMS, connective tissue, etc). Could it someday be added to have a way to enable or disable all the annotations of only a particular class simultaneously?

  • it would be great to have the option of hovering over an object and having the class or a class nickname displayed.

  • when selecting a particular object (by clicking on the right column), it would be nice to also be able to select by clicking a contour and seeing the corresponding entry in the column highlight.

  • when an object is highlighted, it displays lighter than the rest. I think it would be more intuitive to make all non-selected objects become lighter instead.

  • could we have different classes be displayed in different colors (or give a per color selector so the user could change colors at the class level.

@fedorov fedorov changed the title Indicate by color annotations to belong to different ROIs and/or that have different semantics Improvements to ROI presentation and UI support Jan 25, 2024
@fedorov
Copy link
Member Author

fedorov commented Jan 25, 2024

Feedback from Tom G:

being able switch on ALL the ROI’s for a given class would be nice, eg, a button to just turn on all the stroma. Also, it seems like all the ROI’s are the same blue color. Differentiating by class would be helpful, ie necrosis = red; stroma = blue, etc.

@fedorov
Copy link
Member Author

fedorov commented Mar 8, 2024

Example of how contours are shown in Aperio ImageScope (just to take into account while deciding what to do in Slim):

image

@pedrokohler
Copy link
Collaborator

@fedorov can this be closed? We had created other tickets to address these changes:

#193
#194
#195

These have all been addressed and their PRs have been merged already.

@pedrokohler
Copy link
Collaborator

@fedorov my mistake, we actually still have 2 tickets that haven't been addressed about this issue, namely:

#192
#196

@fedorov
Copy link
Member Author

fedorov commented Nov 1, 2024

@pedrokohler I tested in the IDC test tier, and I do not understand why the color of the large annotation in the top part of the image changes color when I select regions for the annotations in the bottom part. I do not understand the logic for highlighting that is implemented right now, it is not intuitive. I suggest we have a quick meeting sometime next week to discuss this.

Image

@curtislisle
Copy link

curtislisle commented Nov 1, 2024 via email

@pedrokohler
Copy link
Collaborator

@pedrokohler I tested in the IDC test tier, and I do not understand why the color of the large annotation in the top part of the image changes color when I select regions for the annotations in the bottom part. I do not understand the logic for highlighting that is implemented right now, it is not intuitive. I suggest we have a quick meeting sometime next week to discuss this.

Can you provide the URL?

@fedorov
Copy link
Member Author

fedorov commented Nov 11, 2024

Sent via slack.

I think it would also be helpful to allow user to choose if regions should be shown as outlines or filled regions.

Also, the choice of the default colors should be revisited to make them more prominent over H&E. The current colors are very hard to see.

image

@fedorov
Copy link
Member Author

fedorov commented Nov 11, 2024

Also, I just realized, for overlapping ROIs, only one label is shown, which can be confusing - in the example below, the same label overlay is provided for what appears as different ROI (probably because they are overlapping). It might be better to show information for all overlapping ROIs under the mouse pointer.
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants