Merge pull request 4GeeksAcademy#133 from UmiKami/10-Create_a_new_function

added unit test

Author: tommygonzaleza

exercises/10-Create_a_new_function/README.es.md

@@ -24,13 +24,13 @@ En este bloque de código estamos declarando una función que recibe un argument
 
 ## 📝 Instrucciones:
 
-1. Completa la función llamada `shortIntroduction()`, que imprima en consola una pequeña introducción de tu persona.
+1. Completa la función llamada `shortIntroduction()` la cual retorna una breve presentación sobre ti.
 
 2. La función deberá tener 3 argumentos: `name`, `profession` y `age`.
 
 3. Estos parámetros se concatenarán de la siguiente manera: `Hello! my name is {name}, my profession is {profession}. I am {age} years old.`
 
-4. Por último, llama la función con los datos en el orden correcto para completar el ejercicio.
+4. Finalmente, dentro de un `console.log()`, llama a la función con los datos en el orden correcto para terminar el ejercicio.
 
 ## 💡 Pista:
 

exercises/10-Create_a_new_function/README.md

@@ -24,13 +24,13 @@ In this block of code we are declaring a function which receives one argument, `
 
 ## 📝 Instructions:
 
-1. Complete the function called `shortIntroduction()`, which prints in the console a short introduction of you.
+1. Complete the function called `shortIntroduction()`, which returns a short introduction of you.
 
 2. The function will ask for 3 arguments: `name`, `profession`, and `age`.
 
 3. They should be concatenated as follows: `Hello! my name is {name}, my profession is {profession}. I am {age} years old.`
 
-4. Finally, call the function with the data in the correct order to finish the exercise.
+4. Finally, inside a `console.log()`, call the function with the data in the correct order to finish the exercise.
 
 ## 💡 Hint:
 

exercises/10-Create_a_new_function/app.js

@@ -1,6 +1,7 @@
 function shortIntroduction() {
   // Complete this function's body and arguments
+  
 }
 
 // Fill the gaps with your data in the correct order
-shortIntroduction(" ", " ", " ")
+console.log(shortIntroduction(" ", " ", " "))

exercises/10-Create_a_new_function/solution.hide.js

@@ -1,7 +1,7 @@
 function shortIntroduction(name, profession, age) {
     // Complete this function's body and arguments
-    console.log("Hello! my name is " + name + ", my profession is " + profession + ". I am " + age + " years old.")
+    return "Hello! my name is " + name + ", my profession is " + profession + ". I am " + age + " years old."
 }
-
+  
 // Fill the gaps with your data in the correct order
-shortIntroduction("Carlos", "Developer", "35")
+console.log(shortIntroduction("Trinity", "Developer", "35"))

exercises/10-Create_a_new_function/test.js

@@ -0,0 +1,20 @@
+const fs = require('fs');
+const path = require('path');
+const rewire = require('rewire');
+
+test('shortIntroduction function exists', () => {
+  const file = rewire("./app.js");
+  const shortIntroduction = file.__get__('shortIntroduction');
+  expect(typeof shortIntroduction).toBe('function');
+});
+
+test("shortIntroduction function returns correct introduction", ()=>{
+
+    const file = rewire("./app.js");
+    const shortIntroduction = file.__get__('shortIntroduction');
+    
+    expect(shortIntroduction("Bob", "developer", 25)).toBe("Hello! my name is Bob, my profession is developer. I am 25 years old.");
+    expect(shortIntroduction("John", "CTO", 43)).toBe("Hello! my name is John, my profession is CTO. I am 43 years old.");
+    expect(shortIntroduction("Tom", "lead developer", 28)).toBe("Hello! my name is Tom, my profession is lead developer. I am 28 years old.");
+    expect(shortIntroduction("Alberto", "CIO", 32)).toBe("Hello! my name is Alberto, my profession is CIO. I am 32 years old.");
+});