Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\t minification #142

Closed
HoraceSupertramp opened this issue Jan 7, 2020 · 2 comments · Fixed by #152
Closed

\t minification #142

HoraceSupertramp opened this issue Jan 7, 2020 · 2 comments · Fixed by #152

Comments

@HoraceSupertramp
Copy link

I just checked the minified output code of an application i developed using this plugin. Comes out that, unlike spaces, none of the tab characters within CSS template literals get omitted during minification.

As an example, the following styled components occurring in my project's code

const Header = styled.div`
	display: flex;
	align-items: center;
	justify-content: space-between;
	font-weight: 600;
	padding: 0.8em 1.6em;
	background: peachpuff;
`;

gets compiled into

a=i.default.div.withConfig({displayName:"Header",componentId:"sc-m1ream"})`	display:flex;	align-items:center;	justify-content:space-between;	font-weight:600;	padding:0.8em 1.6em;	background:peachpuff;`

leaving those tabs behind. Isn't it supposed to remove those too?
Thank you in advance.

@Igorbek Igorbek self-assigned this Jan 21, 2020
@Igorbek Igorbek added the bug label Jan 21, 2020
@Igorbek Igorbek added this to the Release 1.5 milestone Jan 21, 2020
@Igorbek Igorbek added the fixed label Jan 21, 2020
@Igorbek
Copy link
Owner

Igorbek commented Jan 21, 2020

@HoraceSupertramp thank you for the report.
I'm sorry I missed your message first, it just got to my attention.
It's been fixed now and released in 1.4.4

@HoraceSupertramp
Copy link
Author

@Igorbek I shall restore my .prettierrc to tabbed indentation. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants