Grid - conditional cell styling #2588
Conversation
SAndreeva
added
❌ status: awaiting-test
| const defaultClasses = ['igx-grid__td igx-grid__td--fw']; | ||
|
|
||
| if (this.column.cellClasses) { | ||
| Object.entries(this.column.cellClasses).forEach(([name, cb]) => { |
There was a problem hiding this comment.
Object.entries is not supported in IE. Can we add a polyfill for it?
There was a problem hiding this comment.
A polyfill was added with this PR #2279. We will take care to add a note for it in the documentation.
| { field: 'Phone', width: 150, cellClasses: this.cellClasses1 }, | ||
| { field: 'Fax', width: 150, cellClasses: this.cellClasses1 } | ||
| ]; | ||
| this.data = [ |
There was a problem hiding this comment.
I believe you could use SampleTestData.contactInfoData() method here instead of hardcoding the data. The only difference I saw is the lack of numeric data in the SampleTestData. Adding one more numeric field shouldn't break any tests, I hope so.
There was a problem hiding this comment.
contactInfoData() returns a slightly different data. I will simply add one more method to expose mine
There was a problem hiding this comment.
...or find another method.
| @@ -308,17 +308,20 @@ export class IgxColumnComponent implements AfterContentInit { | |||
| @Input() | |||
| public headerClasses = ''; | |||
| /** | |||
| * Sets/gets the class selector of the column cells. | |||
| * Sets a conditional class selector of the column cells. | |||
| * Accepts an object literal where keys are the name of the classes, | |||
There was a problem hiding this comment.
Maybe add 'containing key-value pairs' after 'object literal'.
| @@ -0,0 +1,17 @@ | |||
| :host::ng-deep { | |||
| .test2 { | |||
| color: black !important; | |||
There was a problem hiding this comment.
Yes, when a cell fits two or more conditions, we may want to define which would take precedence...not of great importance, but a possible use case.
…/IgniteUI/igniteui-angular into SAndreeva/conditional-cell-style
SAndreeva
added
💥 status: in-test
npaunov
added
✅ status: verified
Closes #1079 .