Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Material Outlined Input markup to allow for runtime label changes #12221

Closed
simeonoff opened this issue Oct 24, 2022 · 1 comment · Fixed by #12453
Closed

Improve Material Outlined Input markup to allow for runtime label changes #12221

simeonoff opened this issue Oct 24, 2022 · 1 comment · Fixed by #12453
Assignees
@desig9stein
Labels
📈 enhancement input-group material-theme status: inactive Used to stale issues and pull requests ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@simeonoff
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

The outlined material button doesn't support changing of the label value at runtime as the styles/markup are not well suited for such changes.

Describe the solution you'd like

Refactor the markup and styles of the component to more closely match the Ignite UI for Web Components implementation.
@simeonoff simeonoff self-assigned this Oct 24, 2022
@simeonoff simeonoff changed the title Improve Material Outlined Button markup to allow for runtime label changes Improve Material Outlined Input markup to allow for runtime label changes Oct 26, 2022
@simeonoff simeonoff assigned desig9stein and unassigned simeonoff Oct 27, 2022
@simeonoff simeonoff added the 🛠️ status: in-development Issues and PRs with active development on them label Nov 15, 2022
@desig9stein desig9stein mentioned this issue Dec 13, 2022
Merged
14 tasks
@desig9stein desig9stein added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jan 9, 2023
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@desig9stein desig9stein

Labels
📈 enhancement input-group material-theme status: inactive Used to stale issues and pull requests ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(input): use the same design as web components. IgniteUI/igniteui-angular
2 participants
@simeonoff @desig9stein