-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x11: Further improvements to keyboard handling #446
Comments
One thing I forgot to mention was that I believe it's possible to replace the call to obtain the keysym with a call to xcb_key_symbols_get_keysym from the libxcb-keysyms library, which theoretically should help handle all edge cases. However, I'm not 100% sure of that, and, furthermore, it would add a new dependency (.so is about 15 kb), so I thought I should ask first: are we willing to add this new dependency if it significantly improves keyboard handling? |
@ubercomp I think depending on Plus, 15 KiB is almost nothing these days, and I expect using it will handle some tricky corner cases that we may get wrong with out own implementation... at least my experience with input handling code is “there is always one more corner case to handle”, so it seems smart to offload the work to battle-tested components. One more data point: I see in Debian's popcon that 25% of installs have it installed, which is a lot. Most people who have X11 installed will likely have |
@aperezdc that's what I think as well. basically, I can only guarantee the current implementation for the "pc105" keyboard with US layout / keymap. I'll play with libxcb-keysyms when I have some spare time. |
this commit 48dfac2 deserves a dependency with
|
For the record, we have merged support for using |
In #445 we got some of the key modifiers working on X11 thanks to @ubercomp but quoting from the PR description, there are some other improvements that could be still done in the future:
The text was updated successfully, but these errors were encountered: