Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gl: Simplify GL renderer painting #393

Open
aperezdc opened this issue Jan 14, 2022 · 0 comments
Open

gl: Simplify GL renderer painting #393

aperezdc opened this issue Jan 14, 2022 · 0 comments
Assignees
@aperezdc
Labels
enhancement New feature or request
Milestone
Cog 0.20

Comments

@aperezdc
Copy link
Member

We do not need to call glVertexAttribPointer() for each frame inside cog_gl_renderer_pain(). I think we still need the calls to gl{Enable,Disable}VertexAttribArray() before and after glDrawArrays().

The rotation may change at any time during execution, so at least the second call to set the texture UV-mapping would need to be re-applied when it changes. I think we could add a helper cog_gl_renderer_set_rotation() function that takes care of it 🤔

Originally posted by @aperezdc in #392 (comment)
@aperezdc aperezdc self-assigned this Jan 14, 2022
@aperezdc aperezdc added the enhancement New feature or request label Jan 14, 2022
@aperezdc aperezdc added this to the Cog 0.14 milestone Jan 14, 2022
@aperezdc aperezdc mentioned this issue Jan 14, 2022
Merged
@aperezdc aperezdc modified the milestones: Cog 0.14, Cog 0.16 Jun 29, 2022
@aperezdc aperezdc modified the milestones: Cog 0.16, Cog 0.18 Sep 29, 2022
@aperezdc aperezdc modified the milestones: Cog 0.18, Cog 0.20 Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aperezdc aperezdc

Labels
enhancement New feature or request
Projects
None yet
Milestone
Cog 0.20
Development

No branches or pull requests
1 participant
@aperezdc