Fix #245: Don't update user_main_attribute

[jaap3]

No description provided.

[jaap3]

Should be good now (and is rebased on dev)

[tacerus]

Hello,

I stumbled upon this PR after debugging why the email attribute in my Django application would not be updated - and indeed, after commenting the if attr == user_lookup_key part out, it updates the value as expected.

Is there possibly a way to disable the behavior which I am missing? I understand there was an issue as referenced with #245, however it seems some Django applications do not use a separate username field, causing Djangosaml2 to keep the username as the email value.

[peppelinux]

Can you share your djangosaml2 settings here?

[tacerus]

I think it was error with how I used the application - my issue seems to have arised from the IDP serving the username instead of the email address in the NameID, whilst the Django application only used email addresses to store users - which explained me getting usernames inside of the Django email attribute for SAML authenticated users.

I falsely assumed my issues to be caused by djangosaml2.
Apologies for the false alarm and thank you for your response! :-)

[peppelinux]

Thank you for having reached us with a very good analysis

Best