Skip to content

Fix #277: Resolve LOGIN_REDIRECT_URL #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2021
Merged

Fix #277: Resolve LOGIN_REDIRECT_URL #279

merged 1 commit into from
May 26, 2021

Conversation

jaap3
Copy link
Contributor

@jaap3 jaap3 commented May 26, 2021

No description provided.

@jaap3
Copy link
Contributor Author

jaap3 commented May 26, 2021

I tried to cover all possible cases where LOGIN_REDIRECT_URL is used. As there are no tests for ACS_DEFAULT_REDIRECT_URL I chose to ignore it for now. I hope this patch and the added/changed tests are a good starting point to resolve issue #278.

@peppelinux peppelinux merged commit 9949c72 into IdentityPython:master May 26, 2021
@peppelinux
Copy link
Member

You made a great job Thank you,
I'd take some days to make a new release, if this won't be a blocker for you please use the master branch untill we get v1.2.2.

@jaap3 jaap3 deleted the issue277 branch May 27, 2021 07:08
@jaap3 jaap3 mentioned this pull request May 27, 2021
Closed
jaap3 added a commit to jaap3/djangosaml2 that referenced this pull request May 27, 2021
@jaap3
Fix IdentityPython#277: Resolve LOGIN_REDIRECT_URL (IdentityPython#279)
42e4215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaap3 @peppelinux