Attribute generation #100
Merged
Attribute generation #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| *Special contexts* | ||
|
|
||
| For treating the values as a list - eg for interating using mustach, | ||
| use the .values sub-context For instance to synthesize all fist-last |
|
|
||
| from .base import ResponseMicroService | ||
|
|
||
| def _config(f, requester, provider): |
There was a problem hiding this comment.
Do you want to update your code to use the util function added in #99?
There was a problem hiding this comment.
I was planning to do that in a later refactor - dunno if I can cherry-pick that function
|
|
||
| @property | ||
| def value(self): | ||
| if 1 == len(self._values): |
There was a problem hiding this comment.
Just picky but I really find len(self._values) == 1 is much easier to read.
| recipes = _config(self.synthetic_attributes, requester, provider) | ||
| print(context) | ||
| for attr_name, fmt in recipes: | ||
| print(fmt) |
There was a problem hiding this comment.
Rogue print statement
| for attr_name, fmt in recipes: | ||
| print(fmt) | ||
| syn_attributes[attr_name] = [v.strip().strip(';') for v in re.split("[;\n]+", pystache.render(fmt, context))] | ||
| print(syn_attributes) |
There was a problem hiding this comment.
Rogue print statement
| context[attr_name] = MustachAttrValue(attr_name, values) | ||
|
|
||
| recipes = _config(self.synthetic_attributes, requester, provider) | ||
| print(context) |
There was a problem hiding this comment.
Rogue print statement
|
pushed fixes for all review comments except the one that requires merging of #99 |
|
finished the refactor too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is "clean"... I think