Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Icinga/icinga2
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Icinga/icinga2
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: jbrost/dst-playground
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 12 files changed
  • 1 contributor

Commits on Apr 25, 2025

  1. Move GlobalTimezoneFixture to separate file 

    Prepare for adding test cases for DST changes in other files as well.
    @julianbrost
    julianbrost committed Apr 25, 2025
    Configuration menu
    Copy the full SHA
    57c0762 View commit details
    Browse the repository at this point in the history

  2. DST inconsistency fix

    @julianbrost
    julianbrost committed Apr 25, 2025
    Configuration menu
    Copy the full SHA
    8c51b15 View commit details
    Browse the repository at this point in the history

  3. Tests: remove special cases for Windows in icinga_legacytimeperiod/dst 

    Ideally, Icinga 2 should behave consistenly across platforms. These special
cases only existed because mktime() on Windows behaved differently than the
implementation in glibc. With the introduction of Utility::NormalizeTm(),
there's now consistent behavior and the other expected results for windows are
no longer necessary (ideally, they shouldn't have existed in the first place).
    @julianbrost
    julianbrost committed Apr 25, 2025
    Configuration menu
    Copy the full SHA
    464c915 View commit details
    Browse the repository at this point in the history

  4. Don't disable icinga_legacytimeperiod/dst test on Alpine 

    The test was disabled due to a difference in behavior of mktime() between glibc
and musl. This inconsistency was fixed with the introduction of
Utility::NormalizeTm() and Alpine no longer needs this special case.
    @julianbrost
    julianbrost committed Apr 25, 2025
    Configuration menu
    Copy the full SHA
    e5364bc View commit details
    Browse the repository at this point in the history

  5. tmp: run actions in branch

    @julianbrost
    julianbrost committed Apr 25, 2025
    Configuration menu
    Copy the full SHA
    c39924b View commit details
    Browse the repository at this point in the history
Loading