JsonRpcConnection: Raise an exception when trying to send to disconnected clients

yhabteab · yhabteab · commit 5ff044abe743 · 2024-02-21T14:36:57.000+01:00
diff --git a/lib/remote/jsonrpcconnection.cpp b/lib/remote/jsonrpcconnection.cpp
@@ -164,7 +164,7 @@ ConnectionRole JsonRpcConnection::GetRole() const
 void JsonRpcConnection::SendMessage(const Dictionary::Ptr& message)
 {
 	if (m_ShuttingDown) {
-		return;
+		BOOST_THROW_EXCEPTION(std::runtime_error("Cannot send message to already disconnected API client '" + GetIdentity() + "'!"));
 	}
 
 	Ptr keepAlive (this);
@@ -175,7 +175,7 @@ void JsonRpcConnection::SendMessage(const Dictionary::Ptr& message)
 void JsonRpcConnection::SendRawMessage(const String& message)
 {
 	if (m_ShuttingDown) {
-		return;
+		BOOST_THROW_EXCEPTION(std::runtime_error("Cannot send message to already disconnected API client '" + GetIdentity() + "'!"));
 	}
 
 	Ptr keepAlive (this);

Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ ConnectionRole JsonRpcConnection::GetRole() const`
`164`	`164`	`void JsonRpcConnection::SendMessage(const Dictionary::Ptr& message)`
`165`	`165`	`{`
`166`	`166`	`if (m_ShuttingDown) {`
`167`		`- return;`
	`167`	`+ BOOST_THROW_EXCEPTION(std::runtime_error("Cannot send message to already disconnected API client '" + GetIdentity() + "'!"));`
`168`	`168`	`}`
`169`	`169`
`170`	`170`	`Ptr keepAlive (this);`
`@@ -175,7 +175,7 @@ void JsonRpcConnection::SendMessage(const Dictionary::Ptr& message)`
`175`	`175`	`void JsonRpcConnection::SendRawMessage(const String& message)`
`176`	`176`	`{`
`177`	`177`	`if (m_ShuttingDown) {`
`178`		`- return;`
	`178`	`+ BOOST_THROW_EXCEPTION(std::runtime_error("Cannot send message to already disconnected API client '" + GetIdentity() + "'!"));`
`179`	`179`	`}`
`180`	`180`
`181`	`181`	`Ptr keepAlive (this);`