Merge pull request roofstock#18 from Neuromobile/feature-17/separate-json2csv

Separate JSON2CSV function from export method at csv service

Author: matt-armstrong-rs

addon/services/csv.js

@@ -10,79 +10,76 @@ const defaultConfig = {
 export default Ember.Service.extend({
 
   export: function (data, options) {
-
     options = optionize(options, defaultConfig);
 
-    function JSON2CSV(objArray) {
-      var array = typeof objArray != 'object' ? JSON.parse(objArray) : objArray;
+    var csv = this.jsonToCsv(data, options);
 
-      var str = '';
-      var line = '';
+    saveAs(new Blob([csv],{type:"data:text/csv;charset=utf-8"}), options.fileName);
+  },
 
-      if (options.withSeparator) {
-        // add separator identifier;
-        str += `sep=${options.separator}\r\n`;
-      }
+  jsonToCsv(objArray, options) {
+    var array = typeof objArray != 'object' ? JSON.parse(objArray) : objArray;
 
-      // add heading row
-      var head = array[0];
-      for (var i = 0; i < head.length; i++) {
-        var value = head[i] + "";
-        if (i > 0) {
-          line += options.separator;
-        }
-        line += '"' + value.replace(/"/g, '""') + '"';
-      }
+    var str = '';
+    var line = '';
 
-      str += line + '\r\n';
+    if (options.withSeparator) {
+      // add separator identifier;
+      str += `sep=${options.separator}\r\n`;
+    }
 
-      // add items
-      for (var i = 1; i < array.length; i++) {
-        var line = '';
+    // add heading row
+    var head = array[0];
+    for (var i = 0; i < head.length; i++) {
+      var value = head[i] + "";
+      if (i > 0) {
+        line += options.separator;
+      }
+      line += '"' + value.replace(/"/g, '""') + '"';
+    }
 
-        for (var index = 0; index < array[i].length; index++) {
-          var value = array[i][index];
+    str += line + '\r\n';
 
-          if (index > 0) {
-            line += options.separator;
-          }
-          if (typeof value === 'object') {
-            if (value) {
-              var resolveValue;
-              if (value._d instanceof Date) {
-                // dealing with encoding issue in IE browsers.
-                resolveValue = (value._d.getMonth() + 1) + '/' + value._d.getDate()  + '/' + value._d.getFullYear();
-              }
-              else {
-                resolveValue = value._d.toString();
-              }
+    // add items
+    for (var i = 1; i < array.length; i++) {
+      var line = '';
+
+      for (var index = 0; index < array[i].length; index++) {
+        var value = array[i][index];
 
-              line += '"' + resolveValue.replace(/"/g, '""') + '"';
+        if (index > 0) {
+          line += options.separator;
+        }
+        if (typeof value === 'object') {
+          if (value) {
+            var resolveValue;
+            if (value._d instanceof Date) {
+              // dealing with encoding issue in IE browsers.
+              resolveValue = (value._d.getMonth() + 1) + '/' + value._d.getDate()  + '/' + value._d.getFullYear();
             }
             else {
-              line += '""';
+              resolveValue = value._d.toString();
             }
+
+            line += '"' + resolveValue.replace(/"/g, '""') + '"';
           }
           else {
-            value = value + "";
-            if (value && value != 'undefined') {
-              line += '"' + value.replace(/"/g, '""') + '"';
-            }
-            else {
-              line += '""';
-            }
+            line += '""';
+          }
+        }
+        else {
+          value = value + "";
+          if (value && value != 'undefined') {
+            line += '"' + value.replace(/"/g, '""') + '"';
+          }
+          else {
+            line += '""';
           }
         }
-
-        str += line + '\r\n';
       }
-      return str;
-    }
-
-    var csv = JSON2CSV(data);
-
-    saveAs(new Blob([csv],{type:"data:text/csv;charset=utf-8"}), options.fileName);
 
+      str += line + '\r\n';
+    }
+    return str;
   }
-
 });

tests/index.html

@@ -26,6 +26,7 @@
     <script src="assets/dummy.js"></script>
     <script src="testem.js"></script>
     <script src="assets/test-loader.js"></script>
+    <script src="assets/tests.js"></script>
 
     {{content-for 'body-footer'}}
     {{content-for 'test-body-footer'}}

tests/unit/services/csv-test.js

@@ -0,0 +1,28 @@
+import { moduleFor, test } from 'ember-qunit';
+
+moduleFor('service:csv', 'Unit | Service | csv', {
+  // Specify the other units that are required for this test.
+  // needs: ['service:foo']
+});
+
+// Replace this with your real tests.
+test('#jsonToCsv - with valid Array of Arrays, it should return an string with CSV format', function(assert) {
+  const service = this.subject();
+  const array = [
+    [
+      'name',
+      'last_name',
+    ],
+    [
+      'Dale',
+      'Cooper'
+    ],
+  ];
+  const expectedCSV = '\"name\",\"last_name\"\r\n\"Dale\",\"Cooper\"\r\n';
+  const options = {
+    separator: ',',
+    withSeparator: false,
+  };
+
+  assert.deepEqual(service.jsonToCsv(array, options), expectedCSV);
+});