Merge pull request #129 from IShix-g/release

refactor: move package cleanup to upload-package step

Author: IShix-g

.github/workflows/build-package-exporter.yaml

@@ -65,44 +65,8 @@ jobs:
           echo "tag=$latest_release" >> "$GITHUB_OUTPUT"
           echo "::notice title=Latest release::$latest_release"
 
-  check-existing-package:
-    needs: [verify-branch, get-latest-release]
-    runs-on: ubuntu-22.04
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-
-      - name: Check for Existing Package
-        id: check-package
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: |
-          latest_release="${{ needs.get-latest-release.outputs.tag }}"
-          file_name="PackageExporter_.*\\.unitypackage"
-          asset_url=$(gh release view "$latest_release" --json assets -q ".assets[].name" | grep -E "$file_name" || echo "")
-          if [[ -n "$asset_url" ]]; then
-            echo "found=1" >> "$GITHUB_OUTPUT"
-            echo "::notice title=Found file::$asset_url"
-          fi
-
-      - name: Delete Existing Package File
-        if: ${{ steps.check-package.outputs.found == '1' }}
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: |
-          latest_release="${{ needs.get-latest-release.outputs.tag }}"
-          file_name="PackageExporter_.*\\.unitypackage"
-          current_file_name=$(gh release view "$latest_release" --json assets -q ".assets[].name" | grep -E "$file_name")
-          if [[ -n "$current_file_name" ]]; then
-            gh release delete-asset "$latest_release" "$current_file_name"
-            echo "::notice title=Removed asset::$current_file_name"
-          else
-            echo "::notice title=Not removed asset::No matching asset found to remove."
-          fi
-
   update-packagejson:
-    needs: [verify-branch, get-latest-release, check-existing-package]
+    needs: [verify-branch, get-latest-release]
     uses: ./.github/workflows/reusable-update-packagejson.yaml
     secrets:
       BOT_APP_ID: ${{ secrets.BOT_APP_ID }}
@@ -116,7 +80,7 @@ jobs:
       commit-message-format: 'Update the Package Exporter package.json to {v}'
 
   build-package:
-    needs: [verify-branch, get-latest-release, check-existing-package, update-packagejson]
+    needs: [verify-branch, get-latest-release, update-packagejson]
     uses: ./.github/workflows/reusable-build-package.yaml
     secrets:
       UNITY_EMAIL: ${{ secrets.UNITY_EMAIL }}
@@ -129,7 +93,7 @@ jobs:
       commit-id: ${{ needs.update-packagejson.outputs.sha }}
 
   merge-and-push:
-    needs: [verify-branch, get-latest-release, check-existing-package, update-packagejson, build-package]
+    needs: [verify-branch, get-latest-release, update-packagejson, build-package]
     uses: ./.github/workflows/reusable-merge-and-push.yaml
     secrets:
       BOT_APP_ID: ${{ secrets.BOT_APP_ID }}
@@ -141,13 +105,41 @@ jobs:
       dry-run: ${{ inputs.dry-run }}
 
   upload-package:
-    needs: [verify-branch, get-latest-release, check-existing-package, update-packagejson, build-package, merge-and-push]
+    needs: [verify-branch, get-latest-release, update-packagejson, build-package, merge-and-push]
     runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
+      - name: Check for Existing Package
+        id: check-package
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          latest_release="${{ needs.get-latest-release.outputs.tag }}"
+          file_name="PackageExporter_.*\\.unitypackage"
+          asset_url=$(gh release view "$latest_release" --json assets -q ".assets[].name" | grep -E "$file_name" || echo "")
+          if [[ -n "$asset_url" ]]; then
+            echo "found=1" >> "$GITHUB_OUTPUT"
+            echo "::notice title=Found file::$asset_url"
+          fi
+
+      - name: Delete Existing Package File
+        if: ${{ steps.check-package.outputs.found == '1' }}
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          latest_release="${{ needs.get-latest-release.outputs.tag }}"
+          file_name="PackageExporter_.*\\.unitypackage"
+          current_file_name=$(gh release view "$latest_release" --json assets -q ".assets[].name" | grep -E "$file_name")
+          if [[ -n "$current_file_name" ]]; then
+            gh release delete-asset "$latest_release" "$current_file_name"
+            echo "::notice title=Removed asset::$current_file_name"
+          else
+            echo "::notice title=Not removed asset::No matching asset found to remove."
+          fi
+
       - uses: actions/download-artifact@v4
         with:
           name: ${{ needs.build-package.outputs.package-name }}