Ticket2173: Added HRPD sample changer OPI

[DominicOram]

Description of work

See ISISComputingGroup/EPICS-ioc#133

---

Code Review

• Is the code of an acceptable quality?
• Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
• Are there unit tests in place? Are the unit tests small and test the a class in isolation?
• Are there automated system tests in place? Do they test a minimal set of functionality and leave the gui as close as possible to its original state?
• Has the manual system tests spreadsheet been updated?
  • Manual system tests for the functionality should be added if there are no automated tests
  • Manual system tests can be removed from the template if they are covered by suitable automated tests
• Did any existing system test break as a result of the current changes?
• Have the changes been documented in the release notes. If so, do they describe the changes appropriately?
• If an OPI has been modified, does it conform to the style guidelines? There is a script called check_opi_format.py to help with this.

Functional Tests

• Do changes function as described? Add comments below that describe the tests performed.
• How do the changes handle unexpected situations, e.g. bad input?
• Has developer documentation been updated if required?

Final Steps

• Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

[AdrianPotter]

• Please add an icon for the RSC
• Fields (Move Finished, Status) in position group box should be stacked, not side by side
• Labels in the OPI should be in sentence case, not title case (i.e. capital on first word only). Don't forget to run the check_opi_format script, it would have caught this.
• Status and position group boxes should have the same left alignment
• Please use the standard Label: [RBV] [SP] layout for initialization

[AdrianPotter]

Value tag is not closed

[AdrianPotter]

It is now :)

[AdrianPotter]

The gui can't currently parse the opi info XML because of an unclosed tag so no target component types are listed. Might have been an issue with merging with master.

[AdrianPotter]

• After initialising the instrument in DEVSIM mode, it gets stuck in "Moving".
• The position set point box can't be edited
• Would the LED be more intuitive if it was lit when moving and off when not moving?
• Please could the message label and text box in last error be vertically aligned to top rather than centre, as in the Eurotherm
• Any chance we could have a more circular icon? I may have misunderstood the kit but I imagine it's a rotating carousel containing samples? In which case, something like the pinhole selector icon would be more representative.

[DominicOram]

The move finished LED straight from the VI so there is a continuity argument for keeping it. I also think that its intuitive as the light is lit when you are able to put in a new move, im not fussed either way though.

I will add a better icon for the synoptic, the other issues should now be fixed.