Skip to content

Cherry pick release fix #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2020
Merged

Cherry pick release fix #1158

merged 2 commits into from
Jul 21, 2020

Conversation

@DominicOram
Copy link
Contributor

@DominicOram DominicOram commented Jul 21, 2020

Description of work

Contains changes from #1157. Already tested and merged into release by @FreddieAkeroyd.

Code Review

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?
  • Have the changes been documented in the release notes?

Final Steps

  • Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

JamesKingWork and others added 2 commits July 21, 2020 19:46
@FreddieAkeroyd FreddieAkeroyd merged commit 9e9d190 into master Jul 21, 2020
@FreddieAkeroyd FreddieAkeroyd deleted the cherry_pick_release_fix branch July 21, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FreddieAkeroyd FreddieAkeroyd FreddieAkeroyd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DominicOram @FreddieAkeroyd @JamesKingWork