Fix log issue by restarting correctly #1157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set running false before closing consumer
| public void closeJMSConsumer() throws JMSException { | ||
| setRunning(false); | ||
| jmsConsumer.close(); | ||
|
|
Member
There was a problem hiding this comment.
If we close () when it is receiving are we OK i.e. it throws an exception that we catch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
On reconnect actually restart the MessageParser thread to receive messages.
Ticket
ISISComputingGroup/IBEX#5561
Acceptance criteria
Both before and after I have switched instruments and back the following occur:
Unit tests
Give an overview of unit tests you have added or modified, if applicable. The aim is provide information to help the reviewer
System tests
Mention any automated tests or manual tests that you have added or modified, if applicable. The aim is provide information to help the reviewer
Documentation
Highlight and provide a link to any additions or changes to the documentation, if applicable. The aim is provide information to help the reviewer
Code Review
Final Steps