Merge pull request #90 from ISISComputingGroup/add_fwdr_to_base_iocs

add forwarder to base iocs

Author: KathrynBaker

src/common_upgrades/add_to_base_iocs.py

@@ -23,7 +23,7 @@ def __init__(
         self._xml_to_add = xml_to_add
 
     def perform(self, file_access: FileAccess, logger: LocalLogger) -> int:
-        """Add the autostart of the given.
+        """Add the autostart of the given IOC.
 
         Args:
             file_access (FileAccess): file access.

src/upgrade_step_from_25p2p1p1.py

@@ -1,12 +1,21 @@
 from src.common_upgrades import change_pv_in_dashboard as dashboard
+from src.common_upgrades.add_to_base_iocs import AddToBaseIOCs
 from src.file_access import FileAccess
 from src.local_logger import LocalLogger
 from src.upgrade_step import UpgradeStep
 
+XML_TO_ADD = """\
+    <ioc autostart="true" name="FWDR" restart="true" simlevel="none">
+        <macros/>
+        <pvs/>
+        <pvsets/>
+    </ioc>
+"""
+
 
 class UpgradeFrom25p2p1p1(UpgradeStep):
     """
-    Add calculation to dashboard to display when in test clock
+    Add calculation to dashboard to display when in test clock, also add FWDR to base IOCs.
     """
 
     def perform(self, file_access: FileAccess, logger: LocalLogger) -> int:
@@ -35,4 +44,9 @@ def perform(self, file_access: FileAccess, logger: LocalLogger) -> int:
             pass_fail = 1
 
         reader.write_file(file)
-        return pass_fail
+
+        base_ioc_add_success = AddToBaseIOCs("FWDR", "BSKAFKA", XML_TO_ADD).perform(
+            file_access, logger
+        )
+
+        return pass_fail | base_ioc_add_success

upgrade.py

@@ -80,7 +80,7 @@
     ("25.2.1", UpgradeFrom25p2p1()),
     ("25.2.1.1", UpgradeFrom25p2p1p1()),
     ("25.2.2", None),
-    # to add step see https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Config-Upgrader#adding-an-upgrade-step
+    # to add step see README.md
 ]
 
 if __name__ == "__main__":