Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner still displayed after deletion on the current page #9258

Open
stevenferey opened this issue Jan 4, 2023 · 2 comments
Open

Banner still displayed after deletion on the current page #9258

stevenferey opened this issue Jan 4, 2023 · 2 comments
Labels
Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. Feature: Notifications Type: Bug a defect User Role: Guest Anyone using the system, even without an account UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF

Comments

@stevenferey
Copy link
Contributor

What steps does it take to reproduce the issue?

Have a banner displayed on the portal

  • When does this issue occur?

When deleting the banner

  • Which page(s) does it occurs on?

All Pages

  • What happens?

Once a banner is configured (online mode or offline mode), the banner is displayed correctly.
 -> PROBLEM: When a user wants to delete the message (by clicking on the cross), the banner is still displayed on the page.
-> When the user reloads the page or changes the page, the banner is removed.

  • To whom does it occur (all users, curators, superusers)?

all users

  • What did you expect to happen?

A banner removed from the current page

Which version of Dataverse are you using?

5.12.1

Any related open or closed issues to this bug report?

https://groups.google.com/g/dataverse-community/c/TA-iY8j3nuo

@stevenferey
Copy link
Contributor Author

Hello,

Are you interested in a PR on this topic or is it better to wait for Dataverse 6.x in order to attempt to reproduce it?

Thank you so much,
Steven.

@pdurbin
Copy link
Member

pdurbin commented Jul 12, 2023

@stevenferey first, thanks for the offer of a PR!

Are you aware that we are rewriting the Dataverse frontend from JSF to React? We did a demo last month at the community meeting. You can find the latest info here: https://groups.google.com/g/dataverse-community/c/2hfhWIHQddE/m/hATuWGGSAAAJ

It's early days for the React app. You can find the code at https://github.com/IQSS/dataverse-frontend

We haven't even implemented banners there so there's nothing to fix. 😅

So yeah, if you want to fix it on the JSF side, I say you're welcome to go ahead. Or you could wait for the React app where hopefully this bug won't occur! 😄

@pdurbin pdurbin added Type: Bug a defect Feature: Notifications User Role: Guest Anyone using the system, even without an account Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF labels Oct 8, 2023
@DS-INRAE DS-INRAE moved this to 🔍 Interest in Recherche Data Gouv Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. Feature: Notifications Type: Bug a defect User Role: Guest Anyone using the system, even without an account UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF
Projects
Status: 🔍 Interest
Development

No branches or pull requests

2 participants