Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ApiRepository for enhanced generality and abstraction #136

Open
MellyGray opened this issue Mar 22, 2024 · 0 comments
Open

Refactor ApiRepository for enhanced generality and abstraction #136

MellyGray opened this issue Mar 22, 2024 · 0 comments
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows

Comments

@MellyGray
Copy link
Contributor

Overview of the Feature Request

The ApiRepository currently incorporates logic that is specific to particular resource types. This approach limits the generic utility of the repository and necessitates direct checks on these types within the repository itself. The proposal is to enhance the generality of ApiRepository by abstracting away resource-specific logic.

What Inspired the Request?

The need for a more generic ApiRepository was identified during a code review. The current implementation requires direct checks on resource types, which can complicate the codebase and reduce the modularity and reusability of the repository.

What Existing Behavior Do You Want Changed?

None, this is just a refactor.

Any Brand New Behavior Do You Want to Add to js-dataverse?

None, this is just a refactor.

Any Open or Closed Issues Related to This Feature Request?

No

@MellyGray MellyGray added pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows labels Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows
Projects
Status: No status
Development

No branches or pull requests

1 participant