Skip to content

Conversation

Copy link

Copilot AI commented Oct 21, 2025

✅ All review feedback addressed and code quality issues fixed

Changes Made

Commit 2860da0

  1. Removed templates directory
  2. Moved nvm and yarn to developer.sh
  3. Removed telegraf and microk8s
  4. Updated READMEs

Commit 5827e98

Fixed code quality issues:

  • Removed trailing whitespace from shell scripts (user.sh, developer.sh)
  • Removed trailing whitespace from markdown files (README.md)
  • Fixed comment formatting in bash code blocks (added space after #)
  • Ensured consistent formatting throughout

Commit c4e239b

Refactored installation approach based on review:

  • user.sh: Removed Node.js and yarn installation (simplified user installation)
  • user.sh: Added gitlab-runner docker image to user installation
  • developer.sh: Removed gitlab-runner docker pull
  • README.md: Moved gitlab-runner to user container list, removed containers section from developer items, simplified TODO section

Latest Commit

Quality improvements:

  • deploy/vagrant/two-machine/README.md: Simplified installation instructions, removed reference to single-script-install
  • deploy/vagrant/make_boxes/dtaas/developer.sh: Changed [ ! -f to [[ ! -f for modern bash syntax

Final Configuration

User Installation (user.sh)

  • Basic Docker setup with compose plugin
  • All docker containers including gitlab-runner
  • No Node.js installation (users install as needed)

Developer Installation (developer.sh)

  • Node.js v22 via nvm (v0.40.3)
  • npm global packages: serve, pm2, madge
  • Python venv with jupyterlab and mkdocs
  • Development tools: shellcheck, markdownlint, graphviz

Validation

✅ shellcheck passes for all shell scripts
✅ No trailing whitespace
✅ Consistent comment formatting
✅ Updated docker image versions match current deployments
✅ Modern bash syntax with double brackets

Fixes #963

Original prompt

This section details on the original issue you should resolve

<issue_title>Updates to vagrant installation</issue_title>
<issue_description>Tasks:

  • Use the results of PR addressing issue Improve development scripts #962 to port the changes to deploy/vagrant/*.sh scripts
  • Do vagrant templates instead of single Vagrantfile
  • Update docs in
    • deploy/vagrant/make_boxes/dtaas/README.md
    • deploy/vagrant/single-machine/README.md
    • deploy/vagrant/two-machine/README.md
    • all docker and package versions in READMEs
  • create templates for Vagrantfiles in deploy/vagrant

Optional: replace openssl with mkcert</issue_description>

Comments on the Issue (you are @copilot in this section)

@prasadtalasila @copilot create a PR to resolve this issue

Fixes #963


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…mplates

Co-authored-by: prasadtalasila <9206466+prasadtalasila@users.noreply.github.com>
@qltysh
Copy link

qltysh bot commented Oct 21, 2025

All good ✅

Co-authored-by: prasadtalasila <9206466+prasadtalasila@users.noreply.github.com>
@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

Copilot AI changed the title [WIP] Update Vagrant installation with templates and documentation changes Update vagrant installation scripts with nvm, docker compose plugin, and latest versions Oct 21, 2025
Copilot AI requested a review from prasadtalasila October 21, 2025 10:56
Copilot finished work on behalf of prasadtalasila October 21, 2025 10:56
Copy link
Contributor

@prasadtalasila prasadtalasila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot please make the suggested changes. In addition, dedicated templates are not needed. Remove the templates directory.

@prasadtalasila
Copy link
Contributor

@copilot remember to solve the qlty issues as well.

…remove telegraf and microk8s

Co-authored-by: prasadtalasila <9206466+prasadtalasila@users.noreply.github.com>
Copy link
Author

Copilot AI commented Oct 21, 2025

@copilot please make the suggested changes. In addition, dedicated templates are not needed. Remove the templates directory.

Removed templates directory and updated all READMEs to remove template references in commit 2860da0.

Copilot AI changed the title Update vagrant installation scripts with nvm, docker compose plugin, and latest versions Update vagrant installation scripts with updated docker images and improved documentation Oct 21, 2025
Copilot finished work on behalf of prasadtalasila October 21, 2025 12:39
Copilot AI requested a review from prasadtalasila October 21, 2025 12:39
…nt formatting

Co-authored-by: prasadtalasila <9206466+prasadtalasila@users.noreply.github.com>
Copy link
Author

Copilot AI commented Oct 21, 2025

@copilot remember to solve the qlty issues as well.

Fixed qlty issues in commit 5827e98:

  • Removed trailing whitespace from all shell scripts and markdown files
  • Fixed comment formatting in bash code blocks (added space after #)
  • All changes validated with shellcheck

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • webi.sh
    • Triggering command: curl -sS REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot finished work on behalf of prasadtalasila October 21, 2025 12:47
Copy link
Contributor

@prasadtalasila prasadtalasila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot please see the requested changes.

…r.sh, simplify README

Co-authored-by: prasadtalasila <9206466+prasadtalasila@users.noreply.github.com>
Copy link
Author

Copilot AI commented Oct 21, 2025

@copilot please see the requested changes.

All requested changes implemented in commit c4e239b.

Copilot AI requested a review from prasadtalasila October 21, 2025 12:59
Copilot finished work on behalf of prasadtalasila October 21, 2025 12:59
@prasadtalasila
Copy link
Contributor

@copilot In deploy/vagrant/two-machine/README.md file,

replace the following text

If you only want to test the application and are not setting up a production instance,
you can install using [single script install](../../single-script-install.sh).

If you are not in a hurry and would rather have a production instance,
follow the [instructions](../../README.md) of
regular server installation setup to complete the installation.

with this text

Follow the [instructions](../../README.md) of regular server
installation setup to complete the installation.

Also, in deploy/vagrant/make_boxes/dtaas/developer.sh, change the following line

if [ ! -f /usr/share/keyrings/yarnkey.gpg ]

to

if [[ ! -f /usr/share/keyrings/yarnkey.gpg ]]

make sure that the qlty and sonarcube quality checks pass without any issues.

Co-authored-by: prasadtalasila <9206466+prasadtalasila@users.noreply.github.com>
Copy link
Author

Copilot AI commented Oct 21, 2025

@copilot In deploy/vagrant/two-machine/README.md file,

replace the following text
...

Updated in commit 3e89d73:

  • Simplified two-machine README.md installation instructions
  • Changed [ ! -f to [[ ! -f in developer.sh for modern bash syntax
  • All changes validated with shellcheck

@sonarqubecloud
Copy link

Copilot finished work on behalf of prasadtalasila October 21, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updates to vagrant installation

2 participants