-
Notifications
You must be signed in to change notification settings - Fork 70
Update vagrant installation scripts with updated docker images and improved documentation #1354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/distributed-demo
Are you sure you want to change the base?
Update vagrant installation scripts with updated docker images and improved documentation #1354
Conversation
…mplates Co-authored-by: prasadtalasila <9206466+prasadtalasila@users.noreply.github.com>
Co-authored-by: prasadtalasila <9206466+prasadtalasila@users.noreply.github.com>
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
prasadtalasila
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot please make the suggested changes. In addition, dedicated templates are not needed. Remove the templates directory.
|
@copilot remember to solve the qlty issues as well. |
…remove telegraf and microk8s Co-authored-by: prasadtalasila <9206466+prasadtalasila@users.noreply.github.com>
…nt formatting Co-authored-by: prasadtalasila <9206466+prasadtalasila@users.noreply.github.com>
Fixed qlty issues in commit 5827e98:
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
prasadtalasila
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot please see the requested changes.
…r.sh, simplify README Co-authored-by: prasadtalasila <9206466+prasadtalasila@users.noreply.github.com>
|
@copilot In replace the following text If you only want to test the application and are not setting up a production instance,
you can install using [single script install](../../single-script-install.sh).
If you are not in a hurry and would rather have a production instance,
follow the [instructions](../../README.md) of
regular server installation setup to complete the installation.with this text Follow the [instructions](../../README.md) of regular server
installation setup to complete the installation.Also, in if [ ! -f /usr/share/keyrings/yarnkey.gpg ]to if [[ ! -f /usr/share/keyrings/yarnkey.gpg ]]make sure that the qlty and sonarcube quality checks pass without any issues. |
Co-authored-by: prasadtalasila <9206466+prasadtalasila@users.noreply.github.com>
|



✅ All review feedback addressed and code quality issues fixed
Changes Made
Commit 2860da0
Commit 5827e98
Fixed code quality issues:
#)Commit c4e239b
Refactored installation approach based on review:
Latest Commit
Quality improvements:
[ ! -fto[[ ! -ffor modern bash syntaxFinal Configuration
User Installation (user.sh)
Developer Installation (developer.sh)
Validation
✅ shellcheck passes for all shell scripts
✅ No trailing whitespace
✅ Consistent comment formatting
✅ Updated docker image versions match current deployments
✅ Modern bash syntax with double brackets
Fixes #963
Original prompt
Fixes #963
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.