Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IACS Dataset keyword - Multiple errors #928

Closed
fabiovinci opened this issue Mar 7, 2023 · 3 comments
Closed

IACS Dataset keyword - Multiple errors #928

fabiovinci opened this issue Mar 7, 2023 · 3 comments
Labels
deployed in reference validator Solution deployed in production non-breaking change The change makes tests less restrictive and it has no impact on resources already tested
Milestone

Comments

@fabiovinci
Copy link
Collaborator

It seems the test "IACS Dataset Keyword" reports only one error at a time, although there are many.
In this case, after the correction of the first error, the second appears only in the subsequent validation.

It may be more useful for the user to have all error messages in the first validation so that they can be fixed at the same time.

This improvement is under development and will be included in the next release.

image

@fabiovinci
Copy link
Collaborator Author

In order to display all possible errors related to keywords at once, the related test will be split into different assertions.
The related ATS has been modified accordingly.

@arantzaetxebarria
Copy link
Collaborator

The modifications are now in staging environment, @fabiovinci could you please check that all is correct?

Regards

@arantzaetxebarria arantzaetxebarria added ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing and removed under development labels Apr 20, 2023
@arantzaetxebarria arantzaetxebarria added this to the v2023.2 milestone Apr 20, 2023
@fabiovinci
Copy link
Collaborator Author

Dear @arantzaetxebarria,

I tested the fix in staging and it works, so this solution can be included in the next release.

@fabiovinci fabiovinci removed their assignment May 8, 2023
@fabiovinci fabiovinci added solved Solution developed and accepted, not yet deployed and removed ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing labels May 8, 2023
@fabiovinci fabiovinci added the non-breaking change The change makes tests less restrictive and it has no impact on resources already tested label Jun 21, 2023
@jenriquesoriano jenriquesoriano added deployed in reference validator Solution deployed in production and removed solved Solution developed and accepted, not yet deployed labels Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed in reference validator Solution deployed in production non-breaking change The change makes tests less restrictive and it has no impact on resources already tested
Projects
None yet
Development

No branches or pull requests

4 participants