Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery service metadata validation failed for Coupled Resource element #141

Closed
grigoriouelena opened this issue Oct 24, 2019 · 8 comments
Labels
deployed in reference validator Solution deployed in production
Milestone

Comments

@grigoriouelena
Copy link

I am testing a metadata file I have prepared for the national discovery service. I am using the staging instance (24 Oct.), since the validator is not working today.

The file I am testing is:
discovery_md.zip

And the assertion that fails is:
http://staging-inspire-validator.eu-west-1.elasticbeanstalk.com/etf-webapp/v2/TestRuns/EID33edffc1-797e-437b-bea7-b2ac186c4a72.html?lang=en#EID78b5b37f-3565-49df-999e-8ebdbf0318f2.

As I can see in my xml file, there is no operatesOn element.

@grigoriouelena
Copy link
Author

grigoriouelena commented Oct 25, 2019 via email

@danielnavarrogeo
Copy link
Contributor

Dear Elena,

You are right. This element might not be provided but please take a look at this:

The multiplicity of this element is zero or more with the following condition: "Mandatory if linkage to data sets on which the service operates are available".

https://github.com/inspire-eu-validation/metadata/blob/2.0/sds/coupled-resource.md#notes

The test is going to be modified in order to allow not providing this element. I will let you know when it is ready in staging for testing.

Regads,

Daniel

@danielnavarrogeo
Copy link
Contributor

Dear Elena,

The issue has been fixed. You can try in the staging instance.

Regards

@danielnavarrogeo danielnavarrogeo added ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing and removed under development labels Oct 25, 2019
@MarcoMinghini
Copy link
Contributor

Dear @grigoriouelena,
according to the TG we have both that:

  • the multiplicity of the Coupled Resource metadata element is 0..n
  • the element is "mandatory if linkage to data sets on which the service operates are available".

In our opinion, this means in practice that the element is mandatory, since any INSPIRE service you may want to document refers to data set(s) which already exist (i.e. whose metadata is already available).

To keep this into account, the presence of the element might be made mandatory, or a manual check might be added if the element is not present.

The solution implemented is fine for the moment, but this should be further discussed with the sub-group.

@MarcoMinghini MarcoMinghini added the for-2017.4-discussion This issue will be discussed with the sub-group 2017.4 label Oct 25, 2019
@MarcoMinghini MarcoMinghini removed the ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing label Oct 25, 2019
@grigoriouelena
Copy link
Author

Dear Marco, Daniel,

Of course the element should be provided, especially for the discovery service that is operating on data and services metadata.

I was just checking the metadata file before I enter any coupled resources and I ran into a message that was not valid, in my opinion, so I thought I should report it.

I think that a manual check message is a good solution.

Thanks for the effort.

Regards,

Elena

@fabiovinci
Copy link
Collaborator

Dear all,

after reanalyzing the issue, it was verified that a manual check message should be added, as suggested by @grigoriouelena.

The related ATS will be modified and the solution implemented in staging for testing.

@arantzaetxebarria
Copy link
Collaborator

Dear @fabiovinci, all

The solution has been implemented and it is in staging environment. Could you please verify? Thanks

Regards

@arantzaetxebarria arantzaetxebarria added ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing and removed ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing labels Mar 16, 2023
@arantzaetxebarria arantzaetxebarria added ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing and removed under development labels Mar 16, 2023
@fabiovinci
Copy link
Collaborator

Dear @arantzaetxebarria,

I tested it and the fix implemented is fine.

@fabiovinci fabiovinci added solved Solution developed and accepted, not yet deployed and removed ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing labels Mar 16, 2023
@fabiovinci fabiovinci added deployed in reference validator Solution deployed in production and removed solved Solution developed and accepted, not yet deployed labels Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed in reference validator Solution deployed in production
Projects
None yet
Development

No branches or pull requests

6 participants