DefaultJavaPrettyPrinter.visitCtThisAccess

[leventov]

I think it shouldn't rely on getTarget().isImplicit() when printing this qualifier, because classes could be moved around, and Implicit flag is usually not modified.

Such implementation work better for me, probably it should be adapted for DefaultJavaPrettyPrinter itself (+ corner cases, which I omitted in my code because not the case for me):

    class MyPrinter extends DefaultJavaPrettyPrinter {

        Deque<CtClass<?>> currentThis = new ArrayDeque<>();

        public MyPrinter(Environment env) {
            super(env);
        }

        @Override
        public <T> void visitCtClass(CtClass<T> ctClass) {
            currentThis.push(ctClass);
            super.visitCtClass(ctClass);
            currentThis.pop();
        }

        @Override
        public <T> void visitCtThisAccess(CtThisAccess<T> thisAccess) {
            enterCtExpression(thisAccess);
            if (!thisAccess.isImplicit()) {
                if (thisAccess.getType().getDeclaration() != currentThis.peek()) {
                    visitCtTypeReferenceWithoutGenerics(thisAccess.getType());
                    write(".");
                }
                write("this");
            }
            exitCtExpression(thisAccess);
        }
    }

[monperrus]

if it's a bug, could you provide us with a failing test case? thanks.

[monperrus]

Hi @leventov , any news on this? is this really a bug?

[leventov]

@monperrus probably I can pay some time for this, as well as other issues I've reported, next weekend.

[monperrus]

OK, thanks.

[monperrus]

ping @leventov
do you work on this?
(to know whether we wait for your issues for the next release)

[leventov]

@monperrus please don't wait for issues opened by me.