Pre 1.1 mixing

[annejan]

This is mostly a mergein of #124 by @jounathaen and assets by @jsimplicio

Also trying out if this is a good strategy of opening a pull-request early.

[annejan]

Some fallback icons as PoC

Almost as sexy as the native ones 😄

[annejan]

KDE
Gnome

[jsimplicio]

Here are the icons without that button background. I think they'll look best now without that background in actually all interfaces. Let me know what you think. I also changed the update icon because an arrow down doesn't really make much sense for update?

qtpass-icons-nobg.zip

[annejan]

Technically it's git push and git pull the update is still from the first (read only) version.

Thanks, will have some time to play with then after diner I hope 😄

[jsimplicio]

@annejan Oh man so it's pull and push I had no idea. I see. Let me fix it and turn it back to a down arrow then, it makes more sense.

Here is the final set with that pull fixed.

qtpass-icons-final.zip

[jsimplicio]

Just want to recommend using https://github.com/svg/svgo in the future for the icons I've made. If you read this tools description it removes useless and redundant excess info that is exported on the svg when you export it from a program. I used Sketch and it added a lot of fluff to the files.

[annejan]

Done 😁

[jsimplicio]

👍

[jounathaen]

Thanks for merging! Also nice Icons!

[annejan]

Thank you for the awesome effort!
And finding out how the (standard) theme icons work.

I really love how it looks on KDE Plasma.
On Gnome it looks gnomey and fun.
Still want to check out how it looks on other themes and WMs.

And the fallback icons work well on Win and Mac indeed 😄

[jounathaen]

I did a clean pull, but for some reason, the Icons don't work for me. Instead the folder Icons in the treeview have changed to some non system Theme (I use cinnamon). I'll check if this is a problem of my setup...
Now:

Before:

(Maybe this is all a problem of my Linux Installation)
BTW: When I do a make uninstall, it tries to remove my /usr/bin/ which I really want to keep :-D

[annejan]

Wow!!

I'll have a quick look on some more systems when I get home!!
Only tested on Gnome and Plasma on Fedora today.

Those folder icons look like the KDE4 default theme.
It should show your system icons where possible.
There is definately something wrong with the theme handling it seems.

Should currently:

• Take the freedesktop standard theme.
• Fallback to "our" icons.

[jounathaen]

Curiously, in the Qt form designer, the Icons get shown correcty...

[annejan]

I did read something about setting theme from environment a while back.

Interesting development 😉

[jounathaen]

Maybe it is a solution to set the Icons in the mainwindow.cpp and not in the mainwindow.ui ...

[annejan]

Works on everything for me . .
Arch, Fedora, Ubuntu . .

Even nice dark themes 🌘 on both Gnome and KDE

[jounathaen]

Ok, this seems to be a cinnamon specific Problem, I'll open an Issue

[annejan]

Related issue #146