Clear text input: use system icon instead of x

[lightonflux]

I guess this just happened because something had to be in the button, and a label would be too big. Right?

It looks rather prototypy:

Instead the system icon for "clear" should be used. Or better an inline x within the input box.¹ Or even more awesome and better: the inline clear icon of the system/toolkit.

Example (sorry, dark theme):

1: as known from mobile websites and mobile safari

BTW: Just looked at my desktop apps (~120) and qtpass is the only one with a clear button

Oh look, you don't have to do it yourself: https://doc.qt.io/archives/qt-4.7/declarative-ui-components-searchbox.html

Other password managers like keepassx, keepass and last past choose another option. No clear functionality at all.

Source: quick google image search

[annejan]

Nice one . .
Will have to find or design a button image that works on (just about) every theme. I'm thinking white border around a black X.
Since apparently there is no system default button/widget available cross-platform and wm in Qt.
It should be used for the main app search box too.

[lightonflux]

Mozilla does a good job with Firefox's icons. Just don't take VLC or keepass as examples. :)

[annejan]

This is (partially) fixed in #145