Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow arbitrary password generation command #296

Open
edrex opened this issue Feb 20, 2017 · 6 comments
Open

allow arbitrary password generation command #296

edrex opened this issue Feb 20, 2017 · 6 comments

Comments

@edrex
Copy link

edrex commented Feb 20, 2017

I would like to generate passwords using https://pypi.python.org/pypi/xkcdpass/

I tried making a wrapper script that ignores the pwgen args passed, but QtPass seems to check the output and ignore it if it has an unexpected number of characters.

Ask: toggle to just call the supplied pwgen with no args and take the output without validating it.

@annejan
Copy link
Member

annejan commented Feb 20, 2017

This is something I have been thinking about.
And yes, it's something I'd like to see aswel.

I'm waiting for the upcoming release of pass which supports a plugin system and if I recall correctly a straight forward way to select a password generator too.

But if someone else is interested in adding it to 'native' mode already, fee free.

@nh2
Copy link
Contributor

nh2 commented Jan 4, 2018

Of the programs that could potentially generate password, it seems like the most urgent feature would be to allow having pass generate the passwords.

This would have avoided security issues like #338.

I just posted to the pass mailing list (https://lists.zx2c4.com/pipermail/password-store/2018-January/003166.html) to see if there any road blockers to do so. It would be great if QtPass could be used as truly just a GUI around pass, delegating all important operations to it, including password generation.

@jounathaen
Copy link
Member

The problem here is the compatibility with Windows. QtPass aims to work on Win installations without pass or pwgen, therefore it needs to include a password generator.

@nh2
Copy link
Contributor

nh2 commented Jan 4, 2018

it needs to include a password generator

That is OK, as long as as a non-Windows user, I can tell it to use pass (ideally also as the default on non-Windows). I can already tell QtPass to use the pass executable for password storage in the settings, but not yet for password generation.

@annejan
Copy link
Member

annejan commented Jan 4, 2018

This used to also be the case, and will be re-instated in 1.2.2

Pull requests are welcome, since I have only minimal time to work on these needed changes myself.

Unfortunately my schedule in 2017 didn't permit me the time QtPass required to maintain, and repeated appeals to gather more maintainers has sofar failed.

@lukedirtwalker
Copy link
Contributor

pass generate not only generates a password but also creates a file and adds it to git. This would be quite complicated to integrate.

As an intermediate solution instead of actually using pass we could emulate pass generation.

The code is here: https://git.zx2c4.com/password-store/tree/src/password-store.sh#n517 (read -r -n $length pass < <(LC_ALL=C tr -dc "$characters" < /dev/urandom)
so in the QtPass we could use something similar:
cat /dev/urandom | tr -dc 'abc' | fold -w 10 | head -n 1

This would be the "executable" if the pass backend is selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants