Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas.getMaxDimensions does not work for image api 3.0 (and further) #132

Open
nicolasfranck opened this issue Jun 25, 2024 · 0 comments
Open

Comments

@nicolasfranck
Copy link

The current implementation of method Canvas.getMaxDimensions only returns a Size object for images with api 2.0. It checks for a profile where maxWidth and maxHeight are located, while these properties are located in the root in 3.0.

The question is: should IExternalResource be extended with properties in the root (I cannot check canvas.externalResource.data.maxWidth without resetting the type first to any), or should these
properties from image api 3.0 also be put in the same place (profile), even though that api version
never locates them there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant