Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descendant of Attribute type does not seem to work #2

Open
kaicode opened this issue Dec 11, 2015 · 7 comments
Open

Descendant of Attribute type does not seem to work #2

kaicode opened this issue Dec 11, 2015 · 7 comments

Comments

@kaicode
Copy link
Member

kaicode commented Dec 11, 2015

These should not return the same results:
http://localhost:8080/concepts?ecQuery=<<73211009:47429007=*
http://localhost:8080/concepts?ecQuery=<<73211009:<47429007=*

@kaicode kaicode reopened this Apr 19, 2016
@amanlig
Copy link

amanlig commented Nov 17, 2017

HI @kaicode , does this still need work?

@kaicode
Copy link
Member Author

kaicode commented Nov 21, 2017

@amanlig Yes, it still needs work. I've just corrected the queries in the example to make 47429007 |Associated with (attribute)| the attribute. I've rerun those against the July 2017 International release and the service gives the same 16 concepts back which is not correct.

@amanlig
Copy link

amanlig commented Nov 21, 2017

Thanks @kaicode. Can I have a shot at it and submit a fix?

@kaicode
Copy link
Member Author

kaicode commented Nov 21, 2017

Hi @amanlig that would be very helpful, yes please!
Could I please ask that you include a unit test which supports your fix. That would make it easy for us to accept your work and will ensure that this bug doesn't happen again.
Many thanks.

@amanlig
Copy link

amanlig commented Nov 21, 2017

Will do add unit test with it. Thanks @kaicode.

@mkaehlershs
Copy link

is it planned to fix this bug? In the current version this bug is still present:

@kaicode
Copy link
Member Author

kaicode commented Dec 8, 2020

We are not proactively maintaining this project because our main ECL implementation is within the Snowstorm project and we only have limited capacity.
We are making some changes to this project related to our validation processes which use this as a library for MRCM validation.
We welcome contributions from the community for any bug fixes.

Kind regards,
Kai Kewley

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants