This repository has been archived by the owner on Feb 19, 2021. It is now read-only.
Yagil/fix some bugs #107
Open
Yagil/fix some bugs #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hash ends with a null byte too, so we remove this null byte.
The `.decode('utf-8')` is safe because hash holds an hex value,
which is obviously ascii.
One 100% CPU bug One crashing bug Few others
assafnativ
force-pushed
the
yagil/fix_some_bugs
branch
from
656c2ad
to
5e426be
Compare
|
Hi Assafnativ, are you aware of our https://github.com/fidgetingbits/IDArling/ fork? I am currently maintaining it whereas IDArlingTeam repository is not merging Python3 support atm afaict. It would have been nice to merge your changes in my fork - feel free to do a PR indeed but there are lots of changes already that are not in IDArlingTeam. The idea being that we can merge my maintained fork back into IDArlingTeam when they are ready. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.