Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add service_to_service_enabled field to atracker event streams endpoint #5605

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

helenxu1221
Copy link
Contributor

What has been done?

Add service to service authentication for atracker to message hub through the new boolean field service_to_service_enabled in atracker event streams endpoint.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
Helens-IBM:terraform-provider-ibm.helenxu1221 helenxu$ make fmt && make testacc TEST=./ibm/service/atracker TESTARGS='-run=TestAccIBMAtracker.*' gofmt -w $(find .  -path ./.direnv -prune -false -o -name '*.go' |grep -v vendor)
gofmt -w $(find .  -path ./.direnv -prune -false -o -name '*.go' |grep -v vendor)
make: Entering directory `/Users/helenxu/go/src/github.com/IBM-Cloud/terraform-provider-ibm.helenxu1221'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/atracker -v -run=TestAccIBMAtracker.* -timeout 700m
[WARN] Set the environment variable IBM_PROJECTS_CONFIG_APIKEY for testing IBM Projects Config resources, the tests will fail if this is not set
[WARN] Set the environment variable IBM_APPID_TENANT_ID for testing AppID resources, AppID tests will fail if this is not set
[WARN] Set the environment variable IBM_APPID_TEST_USER_EMAIL for testing AppID user resources, the tests will fail if this is not set
...
=== RUN   TestAccIBMAtrackerRoutesDataSourceBasic
--- PASS: TestAccIBMAtrackerRoutesDataSourceBasic (19.10s)
=== RUN   TestAccIBMAtrackerTargetsDataSourceBasic
--- PASS: TestAccIBMAtrackerTargetsDataSourceBasic (15.46s)
=== RUN   TestAccIBMAtrackerTargetsDataSourceAllArgs
--- PASS: TestAccIBMAtrackerTargetsDataSourceAllArgs (16.70s)
=== RUN   TestAccIBMAtrackerRouteBasic
--- PASS: TestAccIBMAtrackerRouteBasic (28.16s)
=== RUN   TestAccIBMAtrackerRouteBasicMultipleRules
--- PASS: TestAccIBMAtrackerRouteBasicMultipleRules (28.08s)
=== RUN   TestAccIBMAtrackerSettingsBasic
--- PASS: TestAccIBMAtrackerSettingsBasic (16.07s)
=== RUN   TestAccIBMAtrackerTargetBasic
--- PASS: TestAccIBMAtrackerTargetBasic (29.82s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/atracker	155.104s
make: *** No rule to make target `gofmt'.  Stop.
make: Leaving directory `/Users/helenxu/go/src/github.com/IBM-Cloud/terraform-provider-ibm.helenxu1221'

Description: "The user password (api key) for the message hub topic in the Event Streams instance.",
Description: "The user password (api key) for the message hub topic in the Event Streams instance. This is required if service_to_service is not enabled.",
},
"service_to_service_enabled": &schema.Schema{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is update behavior for this attribute changing the value after initial creation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user can switch between plain text password and service to service authentication. update to service_to_service_enabled cloud turn service to service authentication on or off.

@hkantare hkantare merged commit 4712cab into IBM-Cloud:master Sep 11, 2024
1 check passed
srikant-sahu pushed a commit to srikant-sahu/terraform-provider-ibm that referenced this pull request Sep 24, 2024
…nt (IBM-Cloud#5605)

* add service_to_service_enabled field to atracker event streams endpoint

* update example

* update go mod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants