add operating system field to workerpool actions #4133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z0za
force-pushed
the
add_os_to_workerpool
branch
2 times, most recently
from
c5e5244
to
992ee1f
Compare
lewiseevans
suggested changes
Nov 7, 2022
ibm/service/kubernetes/data_source_ibm_container_worker_pool.go
Outdated
Show resolved
Hide resolved
ibm/service/kubernetes/resource_ibm_container_vpc_cluster_test.go
Outdated
Show resolved
Hide resolved
ibm/service/kubernetes/resource_ibm_container_vpc_cluster_test.go
Outdated
Show resolved
Hide resolved
lewiseevans
suggested changes
Nov 7, 2022
lewiseevans
approved these changes
Nov 7, 2022
z0za
force-pushed
the
add_os_to_workerpool
branch
from
6494f20
to
ff4e34d
Compare
hkantare
reviewed
Nov 10, 2022
| @@ -214,6 +214,7 @@ Review the argument references that you can specify for your resource. | |||
| - `machine_type` - (Optional, Forces new resource, String) The machine type for your worker node. The machine type determines the amount of memory, CPU, and disk space that is available to the worker node. For an overview of supported machine types, see [Planning your worker node setup](https://cloud.ibm.com/docs/containers?topic=containers-planning_worker_nodes). You can retrieve the value by executing the `ibmcloud ks machine-types <data-center>` command in the IBM Cloud CLI. | |||
| - `name` - (Required, Forces new resource, String) The name of the cluster. The name must start with a letter, can contain letters, numbers, and hyphen (-), and must be 35 characters or fewer. Use a name that is unique across regions. The cluster name and the region in which the cluster is deployed form the fully qualified domain name for the Ingress subdomain. To ensure that the Ingress subdomain is unique within a region, the cluster name might be truncated and appended with a random value within the Ingress domain name. | |||
| - `no_subnet` - (Optional, Forces new resource, Bool) If set to **true**, no portable subnet is created during cluster creation. The portable subnet is used to provide portable IP addresses for the Ingress subdomain and Kubernetes load balancer services. If set to **false**, a portable subnet is created by default. The default is **false**. | |||
| - `operating_system` - (Optional, String) The operating system of the workers in the default worker pool. | |||
There was a problem hiding this comment.
Can we add a link to the cloud doc to get the valid values for operating_systme?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing: