Support SAP deployment type #3822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yussuf Shaikh <yussuf.shaikh1@ibm.com>
|
@hkantare please help with the review. Need this one in the next release. |
hkantare
reviewed
Jun 6, 2022
| @@ -89,6 +89,7 @@ Review the argument references that you can specify for your resource. | |||
| - `pi_replication_scheme` - (Optional, String) The replication scheme that you want to set, either `prefix` or `suffix`. | |||
| - `pi_sap_profile_id` - (Optional, String) SAP Profile ID for the amount of cores and memory. | |||
| - Required only when creating SAP instances. | |||
| - `pi_sap_deployment_type` - (Optional, String) Custom SAP deployment type information (For Internal Use Only). | |||
There was a problem hiding this comment.
if its only for internal use shoudl we document this?
There was a problem hiding this comment.
We are not disclosing the value this parameter takes so think it is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yussuf Shaikh yussuf.shaikh1@ibm.com
Community Note
Relates OR Closes #0000
Output from acceptance testing: