Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support taints during node creation #624

Closed
jfeddern opened this issue Jul 1, 2019 · 5 comments
Closed

Support taints during node creation #624

jfeddern opened this issue Jul 1, 2019 · 5 comments
Labels
service/Kubernetes Service Issues related to Kubernetes Service Issues

Comments

@jfeddern
Copy link

jfeddern commented Jul 1, 2019

Hi there,

we would like to have the ability to add taints to a kubernetes node during the creation of a node.
Currently we have to add all taints after the kubernetes cluster is created. Which lead to some more or less complex terraform setup.

I would suggest to add this functionality to the ibm_container_worker_pool resource (https://ibm-cloud.github.io/tf-ibm-docs/v0.17.1/r/container_worker_pool.html)

Some other providers already support this solution (e.g. google https://www.terraform.io/docs/providers/google/r/container_cluster.html#taint)

@greglanthier
Copy link

This would be pretty handy. Some IKS best practice documents include steps to taint edge nodes to avoid having non-networking workloads scheduled on them (Securing Containers Workload Patterns in IKS is only one example).

It would be cool if we didn't need to run the following kubectl command after our clusters were created:

kubectl taint node -l dedicated=edge dedicated=edge:NoSchedule dedicated=edge:NoExecute

@hkantare
Copy link
Collaborator

The current version of IKS doesn't support any taint option. We will open a support ticket on IKS team for the requirement.

@sh0m1
Copy link

sh0m1 commented Jul 8, 2020

Since recently it is possible to taint all the nodes in a worker pool via ibmcloud cli command ibmcloud ks worker-pool taint set. Since there is the API support for this I would assume that there are no obstacles having terraform implementation of this in ibm_container_vpc_worker_pool resource?

@jfeddern
Copy link
Author

#1646

@hkantare
Copy link
Collaborator

We will plan in next upcoming sprints

@kavya498 kavya498 added the service/Kubernetes Service Issues related to Kubernetes Service Issues label Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/Kubernetes Service Issues related to Kubernetes Service Issues
Projects
None yet
Development

No branches or pull requests

5 participants