Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample code and getClient() does not match gp service properly #9

Closed
2 of 3 tasks
srl295 opened this issue Dec 23, 2015 · 1 comment
Closed
2 of 3 tasks

Sample code and getClient() does not match gp service properly #9

srl295 opened this issue Dec 23, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@srl295
Copy link
Contributor

srl295 commented Dec 23, 2015

As noted in an internal report, "Here the cfenv AppEnv method "getServiceCreds" is used to match the service name based on the regular expression spec, and will return its Credentials property if matched. (see https://www.npmjs.com/package/cfenv#appenv-getservicecreds-spec .) "

Basically, as is the service is expecting the service name to match gp-* when it should look for the label.

See: cloudfoundry-community/node-cfenv#3

Todo:

  • Document how to specify the service name to match
  • look at how to match gp-* as a label
  • contribute upstream to cfenv?
@srl295
Copy link
Contributor Author

srl295 commented Dec 23, 2015

Note that in the sample code this problem was masked because of IBM-Cloud/gp-nodejs-sample#3

@srl295 srl295 added this to the v1.1.4 milestone Jan 7, 2016
@srl295 srl295 closed this as completed in 2641e82 Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant