Skip to content

Commit e595c84

Browse files
committed
[SPARK-32408][BUILD] Enable crossPaths back to prevent side effects
### What changes were proposed in this pull request? This PR proposes to enable `corssPaths` back for now to match with the build as it was. It still indeterministically doesn't run JUnit tests given my observation, and this PR basically reverts the partial fix from apache#29057. See also apache#29205 for the full context. ### Why are the changes needed? To prevent the side effects from crossPaths such as SPARK_PREPEND_CLASSES or tests that run conditionally if the test classes are present in PySpark. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Manually tested: ```bash build/sbt -Phadoop-2.7 -Phive -Phive-2.3 -Phive-thriftserver -DskipTests clean test:package ./python/run-tests --python-executable=python3 --testname="pyspark.sql.tests.test_dataframe QueryExecutionListenerTests" ``` Closes apache#29218 from HyukjinKwon/SPARK-32408-1. Authored-by: HyukjinKwon <gurwls223@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
1 parent b1dc02c commit e595c84

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

project/SparkBuild.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -934,8 +934,6 @@ object TestSettings {
934934
// Show full stack trace and duration in test cases.
935935
testOptions in Test += Tests.Argument("-oDF"),
936936
testOptions in Test += Tests.Argument(TestFrameworks.JUnit, "-v", "-a"),
937-
// Required to detect Junit tests for each project, see also https://github.com/sbt/junit-interface/issues/35
938-
crossPaths := false,
939937
// Enable Junit testing.
940938
libraryDependencies += "com.novocode" % "junit-interface" % "0.11" % "test",
941939
// `parallelExecutionInTest` controls whether test suites belonging to the same SBT project

0 commit comments

Comments
 (0)