Skip to content

Added project reactor transport - reactive rate limiting (Tested) #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 55 commits into from
Jul 26, 2021
Merged

Added project reactor transport - reactive rate limiting (Tested) #425

merged 55 commits into from
Jul 26, 2021

Conversation

GrizzlT
Copy link
Contributor

@GrizzlT GrizzlT commented May 11, 2021

This transport allows for automatic rate limiting using the project reactor core and netty libraries.

@ConnorLinfoot
Just a start/idea of what we have in mind for 4.0. All subject to cha…
5433cba 
…nge.
@ConnorLinfoot
Add HTTPQueryParams for some cleaner handling over an array
75e7b01
@ConnorLinfoot
Add a README.md here and remove PlayerCountReply.java
db810c9
@ConnorLinfoot
Add ApacheHTTPClient to Example
2475435
@ConnorLinfoot
Merge branch 'master' into 4.0.0
79512a1
@ConnorLinfoot
checkReply return the same type
ffefdf6
@ConnorLinfoot
Merge branch 'master' into 4.0.0
964e8b3 
# Conflicts:
#	README.md
@ConnorLinfoot
Add comment for issue 249
a9baafa
@ConnorLinfoot
Tweak doc
4665b53
@ConnorLinfoot
Some more tweaks towards javadocs etc
643ae52
@ConnorLinfoot
Merge branch 'master' into 4.0.0
bc7d17a
@ConnorLinfoot
Merge branch 'master' into 4.0.0
c3e69f5
@ConnorLinfoot
Move SkyBlockBazaarReply to use longs instead of ints
cda8ec7 
Fixes #274
@ConnorLinfoot
Fix Bazaar Example
f3c8a6d
@ConnorLinfoot
Add a comment about the recent change to the name endpoint
9e6dfd3
@ConnorLinfoot
Merge branch 'master' into 4.0.0
ef86bc8
@ConnorLinfoot
Make member static
98d3f15
@ConnorLinfoot
Add REPLAY and SMP GameType
edc181b
@ConnorLinfoot
Readme
25eed71
@ConnorLinfoot
Some tweaks, API Key is now passed and only handdled by the HTTP Client
ab05344
@ConnorLinfoot
Move a lot of things
71d8bf1
@ConnorLinfoot
Readme changes
d79e4c2
@ConnorLinfoot
Readme changes
1439a17
@ConnorLinfoot
Update README.md
8eef69d
@ConnorLinfoot
update license time
e4534c0
@ConnorLinfoot
Remove these, will make sure its all on the main docs
7f1fea8
@ConnorLinfoot
Example link
4cecf98
@ConnorLinfoot
tweaks
44dac46
@ConnorLinfoot
Tweak
b153827
@ConnorLinfoot
Link direct to README.md
687a737
@GrizzlT GrizzlT mentioned this pull request May 11, 2021
Closed
@GrizzlT GrizzlT marked this pull request as ready for review May 11, 2021 14:01
@GrizzlT GrizzlT mentioned this pull request May 11, 2021
Closed
@GrizzlT GrizzlT marked this pull request as draft May 11, 2021 15:03
HydroPage
HydroPage suggested changes May 11, 2021
View reviewed changes
Copy link
Contributor

@HydroPage HydroPage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't sweep the entire file. But I believe the documentation can be a lot more conventional and concise

@GrizzlT
Copy link
Contributor Author

GrizzlT commented May 11, 2021

I assume it's pretty obvious I don't know how to write good documentation (yet). Thank you (@HydroPage ) for all the tips and I hope this looks better.

@GrizzlT GrizzlT marked this pull request as ready for review May 11, 2021 21:25
@GrizzlT GrizzlT marked this pull request as draft May 12, 2021 17:00
@GrizzlT GrizzlT marked this pull request as ready for review May 13, 2021 19:18
@GrizzlT GrizzlT changed the title Added reactive transport - non-blocking rate limiting Added reactive transport - non-blocking rate limiting (Tested) May 13, 2021
@GrizzlT GrizzlT changed the title Added reactive transport - non-blocking rate limiting (Tested) Added reactive transport - reactive rate limiting (Tested) May 13, 2021
@GrizzlT GrizzlT changed the title Added reactive transport - reactive rate limiting (Tested) Added project reactor transport - reactive rate limiting (Tested) May 13, 2021
@ConnorLinfoot ConnorLinfoot deleted the branch HypixelDev:master July 26, 2021 11:41
@ConnorLinfoot
Copy link
Member

Oh this got closed cause of the branch being deleted, will still look at merging your changes

@ConnorLinfoot ConnorLinfoot reopened this Jul 26, 2021
@ConnorLinfoot ConnorLinfoot changed the base branch from 4.0.0 to master July 26, 2021 12:07
@ConnorLinfoot ConnorLinfoot merged commit 1eea3d9 into HypixelDev:master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HydroPage HydroPage HydroPage requested changes

@ConnorLinfoot ConnorLinfoot ConnorLinfoot approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GrizzlT @ConnorLinfoot @HydroPage