Feature 224

[Sidqui-Youssef]

We, @Sidqui-Youssef @lucas-rubagotti @Amine-jabote @FredWantou @IlanPin @nasschml , hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.

[benel]

Thank you for your contribution @Sidqui-Youssef @lucas-rubagotti @Amine-jabote @FredWantou @IlanPin @nasschml.
Whereas tests pass, your pull request is still draft. Is that on purpose?

[benel]

Thank you for your contribution @Sidqui-Youssef @lucas-rubagotti @Amine-jabote @FredWantou @IlanPin @nasschml.

I tested your feature on the sole existing sample with speech turns:

It seems that it works on "Diane" but not on "Responsable d'opération".

Moreover, I understood from past talks that you chose a solution in which the stored text was changed so that the user can edit the automatic bold texts manually (to add or remove some).

But it seems that bold markup is not stored at all. It could be like that, but this behaviour does not correspond to what was discussed earlier, does it ?

[benel]

If you plan to amend your commits, please get first the last version I pushed (instead of your local versions, and please don't merge them).

[Sidqui-Youssef]

Hello Sir,
@Amine-jabote and @Sidqui-Youssef , we've taken your comments into account.
Indeed, regarding the issue with the "Responsable d'opération", it was only a small fix to be made to the Regex of the "Boldspeakernames" function.

Furthermore, regarding the storage of bolding, we tried to implement it by storing the words in bold. However, during the push, we noticed that this caused problems in other tests, other than our own, "EditContent."
When we tried to understand the reason, we noticed that there was an issue with the tests related to the parsing functionality. Instead of modifying the parsing functionality and the various test scenarios involved, we favored the solution with the fewest changes so as not to impact the existing elements, so we tried to respect the main objective of the feature, which was to bold the speakers. We informed the stakeholder about this change, and they confirmed that there were no problems since the most important thing is that the contacts are in bold.

Thank you sir, for your time and guidance.
Best regards.

[benel]

@Amine-jabote and @Sidqui-Youssef , we've taken your comments into account.
Indeed, regarding the issue with the "Responsable d'opération", it was only a small fix to be made to the Regex of the "Boldspeakernames" function.

Thanks. Please don't forget to amend commit 931375a (the one in this remote branch) and push it with force.