Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to React Native 0.74.5 #791

Merged
merged 10 commits into from
Aug 6, 2024
Merged

chore: Upgrade to React Native 0.74.5 #791

merged 10 commits into from
Aug 6, 2024

Conversation

lorenjohnson
Copy link
Member

@lorenjohnson lorenjohnson commented Aug 5, 2024

Seems to be all working in peripheral testing, but a deeper pass of testing is a necessity either before or after merge to dev (if we want to save this for part of release QA):


Adoption (local dev):

  • Install Java 17. It is now required for Android builds vs 11 which was the requirement before. This works for that: brew install --cask zulu@17

@lorenjohnson lorenjohnson changed the title DRAFT: Upgrade to React Native 0.74.4 DRAFT: Upgrade to React Native 0.74.5 Aug 5, 2024
@lorenjohnson lorenjohnson changed the title DRAFT: Upgrade to React Native 0.74.5 Upgrade to React Native 0.74.5 Aug 6, 2024
@lorenjohnson lorenjohnson changed the title Upgrade to React Native 0.74.5 chore: Upgrade to React Native 0.74.5 Aug 6, 2024
Copy link
Contributor

@thomasgwatson thomasgwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lorenjohnson lorenjohnson added this to the HyloApp 5.7.1 milestone Aug 6, 2024
Copy link

gitguardian bot commented Aug 6, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11948920 Triggered Sentry User Auth Token dd5b886 android/sentry.properties View secret
11948920 Triggered Sentry User Auth Token dd5b886 ios/sentry.properties View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@lorenjohnson
Copy link
Member Author

I have manually tested this on both iOS (Simulator and my phone) and Android in emulation. Everything I have tried, including the list of items above, looks to be working as before and stable. I however will not be surprised if we find a thing or two related to this upgrade as we move forward and implicitly test things as we develop/ our next "release QA". I'm will merge now with that understanding to keep keep things moving, and hoping that is ok.

@lorenjohnson lorenjohnson merged commit f617895 into dev Aug 6, 2024
2 checks passed
@lorenjohnson lorenjohnson deleted the rn0.74.4 branch August 6, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants