-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade to React Native 0.74.5 #791
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
11948920 | Triggered | Sentry User Auth Token | dd5b886 | android/sentry.properties | View secret |
11948920 | Triggered | Sentry User Auth Token | dd5b886 | ios/sentry.properties | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
I have manually tested this on both iOS (Simulator and my phone) and Android in emulation. Everything I have tried, including the list of items above, looks to be working as before and stable. I however will not be surprised if we find a thing or two related to this upgrade as we move forward and implicitly test things as we develop/ our next "release QA". I'm will merge now with that understanding to keep keep things moving, and hoping that is ok. |
Seems to be all working in peripheral testing, but a deeper pass of testing is a necessity either before or after merge to dev (if we want to save this for part of release QA):
Adoption (local dev):
brew install --cask zulu@17