Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Public repo preparation #784

Merged
merged 9 commits into from
Aug 6, 2024
Merged

chore: Public repo preparation #784

merged 9 commits into from
Aug 6, 2024

Conversation

lorenjohnson
Copy link
Member

@lorenjohnson lorenjohnson commented Aug 3, 2024

  • Transcribes CODE_OF_CONDUCT.md, CONTRIBUTING.md, and LICENSE from hylo-evo. Adds note in README referencing these (copied from hylo-evo)
  • Removes the release walkthrough video link. I'm pretty sure this at least visually may show things that are not public--that note and link is now in a 1Password as a secure note (will send link in Slack).
  • Removes Fastlane entirely. This was used for iOS certificate provisioning which I've now setup to be automatic, but it was also setup for automatically pushing releases to the store, which hadn't worked or been used in some time. It needed to go anyway, but within the static files it included the login/password to the demo account.

Once this is merged, do the following:

NOTE: Look to 1Password for latest HYLO_REACT_NATIVE env file, there are a couple Sentry properties you'll need there to do Archive builds locally without failure (not an issue for normal dev builds).

Copy link
Contributor

@thomasgwatson thomasgwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lorenjohnson lorenjohnson linked an issue Aug 4, 2024 that may be closed by this pull request
@lorenjohnson lorenjohnson changed the title Prepare to make public repo (feat): Public repo preparation Aug 4, 2024
@lorenjohnson
Copy link
Member Author

lorenjohnson commented Aug 4, 2024

Ah! I had almost forgotten about the sentry.properties files which @tibetsprague you astutely identified in your analysis in #353. The need for these files was actually deprecated in the last Sentry update I made, and I had forgotten to delete them already. Deleted now as part of this PR. These files remain but everything but a default value has been moved into env vars, the current version of the Sentry React Native plugin fails if these files don't exist though all of the relevant values can otherwise be in env vars which they now are.

Copy link

gitguardian bot commented Aug 4, 2024

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11948920 Triggered Sentry User Auth Token db79fc9 ios/sentry.properties View secret
11948920 Triggered Sentry User Auth Token db79fc9 android/sentry.properties View secret
11948920 Triggered Sentry User Auth Token 78ff5fc ios/sentry.properties View secret
11948920 Triggered Sentry User Auth Token 83c4c69 ios/sentry.properties View secret
11948920 Triggered Sentry User Auth Token 83c4c69 android/sentry.properties View secret
11948920 Triggered Sentry User Auth Token 78ff5fc android/sentry.properties View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@lorenjohnson lorenjohnson changed the title (feat): Public repo preparation (chore): Public repo preparation Aug 4, 2024
@lorenjohnson lorenjohnson changed the title (chore): Public repo preparation chore: Public repo preparation Aug 4, 2024
@lorenjohnson
Copy link
Member Author

lorenjohnson commented Aug 5, 2024

@tibetsprague this is pending your review as this two me is a good one for "2 reviewers". However I did 2 more places I need to move secrets android/app/src/main/java/com/hylo/hyloandroid/MainApplication.java and ios/HyloReactNative/AppDelegate.mm where there are Intercom API keys and IDs. Will handle that shortly. If you review before then assume that is taken care of, if that makes sense.

Copy link
Contributor

@tibetsprague tibetsprague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing!

@lorenjohnson lorenjohnson merged commit 1d100ff into dev Aug 6, 2024
2 checks passed
@lorenjohnson lorenjohnson deleted the prepare-for-public branch August 6, 2024 09:33
@lorenjohnson
Copy link
Member Author

Merged with comment on #353 for remaining tasks

@lorenjohnson lorenjohnson added this to the HyloApp 5.7.1 milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open source the mobile app repo
3 participants