-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Public repo preparation #784
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Ah! I had almost forgotten about the |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
11948920 | Triggered | Sentry User Auth Token | db79fc9 | ios/sentry.properties | View secret |
11948920 | Triggered | Sentry User Auth Token | db79fc9 | android/sentry.properties | View secret |
11948920 | Triggered | Sentry User Auth Token | 78ff5fc | ios/sentry.properties | View secret |
11948920 | Triggered | Sentry User Auth Token | 83c4c69 | ios/sentry.properties | View secret |
11948920 | Triggered | Sentry User Auth Token | 83c4c69 | android/sentry.properties | View secret |
11948920 | Triggered | Sentry User Auth Token | 78ff5fc | android/sentry.properties | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
@tibetsprague this is pending your review as this two me is a good one for "2 reviewers". However I did 2 more places I need to move secrets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing!
Merged with comment on #353 for remaining tasks |
CODE_OF_CONDUCT.md
,CONTRIBUTING.md
, andLICENSE
from hylo-evo. Adds note in README referencing these (copied from hylo-evo)Once this is merged, do the following:
SENTRY_AUTH_TOKEN
in your local.env
and in the project level Bitrise Workflow env vars accordingly.NOTE: Look to 1Password for latest HYLO_REACT_NATIVE env file, there are a couple Sentry properties you'll need there to do Archive builds locally without failure (not an issue for normal dev builds).