1.1.5

Author: Alexia

CHANGES.md

@@ -1,4 +1,9 @@
 #Changes
+##1.1.5
+* Fixed an incorrect call to makeErrorBox().
+* Fixed checking titles for existence that in some cases would fail with a fatal error.
+* Fixed central repositories trying to work through a ForeignDBRepo when SpriteSheet only supports ForeignAPIRepo.
+
 ##1.1.4
 * Fixed MediaWiki 1.26+ compatibility.
  * Removed jQuery dependency in resource loader module

README.wiki

@@ -4,10 +4,10 @@
 |status      = stable
 |type        = parser function
 |author      = Alexia E. Smith ([[User:Alexia E. Smith|Alexia E. Smith]]), Hydra Wiki Platform Team
-|version     = 1.1.4
-|update      = 2016-07-23
+|version     = 1.1.5
+|update      = 2016-11-07
 |mediawiki   = 1.23+
-|php         = 5.4+
+|php         = 5.5+
 |download    = {{ {{TNTN|GithubDownload}} |HydraWiki|SpriteSheet}}
 |hook1       = ParserFirstCallInit
 |hook2       = ImagePageShowTOC
@@ -31,7 +31,7 @@ The '''SpriteSheet''' extension allows uploaded images to be divided into sprite
 
 {{{{TNTN|ExtensionInstall}}
 |db-update=true
-|download-link=[https://github.com/HydraWiki/SpriteSheet/archive/v1.1.4.zip Download]}}
+|download-link=[https://github.com/HydraWiki/SpriteSheet/archive/v1.1.5.zip Download]}}
 
 ==Configuration==
 There are two available rights that may be assigned to groups, 'edit_sprites' and 'spritesheet_rollback'.  The 'edit_sprites' permission gives the ability to edit sprite sheets, sprites, slices, assign names, and delete.  The 'spritesheet_rollback' allows the ability to rollback changes from the change log.

SpriteSheet.hooks.php

@@ -161,12 +161,12 @@ static public function generateSpriteOutput(Parser &$parser, PPFrame $frame, $ar
 
 		$title = Title::newFromDBKey($parameters['file']);
 
-		if ($title->isKnown()) {
+		if ($title !== null && $title->isKnown()) {
 			$spriteSheet = SpriteSheet::newFromTitle($title, true);
 
 			if (!$spriteSheet->getId() || !$spriteSheet->getColumns() || !$spriteSheet->getRows()) {
 				//Either a sprite sheet does not exist or has invalid values.
-				return self::makeError('no_sprite_sheet_defined', [$title->getPrefixedText()]);
+				return self::makeErrorBox('no_sprite_sheet_defined', [$title->getPrefixedText()]);
 			}
 
 			if (!empty($parameters['name'])) {
@@ -250,7 +250,7 @@ static public function generateSliceOutput(Parser &$parser, PPFrame $frame, $arg
 
 		$title = Title::newFromDBKey($parameters['file']);
 
-		if ($title) {
+		if ($title !== null) {
 			$spriteSheet = SpriteSheet::newFromTitle($title, true);
 
 			if ($spriteSheet !== false) {

SpriteSheet.php

@@ -13,7 +13,7 @@
 /******************************************/
 /* Credits								  */
 /******************************************/
-define('SPRITESHEET_VERSION', '1.1.4');
+define('SPRITESHEET_VERSION', '1.1.5');
 $credits = [
 	'path'				=> __FILE__,
 	'name'				=> 'SpriteSheet',

classes/SpriteSheet.php

@@ -892,7 +892,7 @@ public function load($row = null) {
 		if (!$this->isLoaded) {
 			$this->image = wfFindFile($this->getTitle());
 
-			if ($this->image !== false && $this->image->exists() && !$this->image->isLocal()) {
+			if ($this->image !== false && $this->image->exists() && !$this->image->isLocal() && $this->image->getRepo() instanceof ForeignAPIRepo) {
 				$query = [
 					'action'	=> 'spritesheet',
 					'do'		=> 'getSpriteSheet',

extension.json

@@ -1,6 +1,6 @@
 {
 	"name": "SpriteSheet",
-	"version": "1.1.4",
+	"version": "1.1.5",
 	"author": [
 		"Curse Inc. Wiki Platform Team",
 		"Alexia E. Smith"