Fix ByteSize not handling default formatting correctly #954
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #953
dev
branch (more info below)fixes #<the issue number>
build.cmd
orbuild.ps1
and ensure there are no test failuresTurns out that Humanizer was handling formatting wrong in two ways, unlike the issue mentions.
null
provider. The same MSDN article defaults to the current culture in its samples, which I'd say is a sane default.The added test will test both of these scenarios, by providing
("G", null)
as args.