Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Humanize(LetterCasing.Sentence) does not remove commas #1185

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

louis-z
Copy link
Contributor

@louis-z louis-z commented Mar 4, 2022

  • Adapt code so that mid-sentence punctuation is kept when humanizing to a sentence
  • Split a regex into simpler constituent parts, easier to reason about
  • Add tests

Fixes #958

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No Code Analysis warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the main branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

@SimonCropp SimonCropp added this to the v3.0 milestone Feb 15, 2024
@SimonCropp
Copy link
Collaborator

thanks for the contribution

@SimonCropp SimonCropp enabled auto-merge (squash) February 15, 2024 13:28
- Adapt code so that mid-sentence punctuation is kept when humanizing to a sentence
- Split a regex into simpler constituent parts, easier to reason about
- Add tests
auto-merge was automatically disabled February 15, 2024 22:19

Head branch was pushed to by a user without write access

@louis-z
Copy link
Contributor Author

louis-z commented Feb 15, 2024

thanks for the contribution

Sure, no problem. I just rebased my branch. It was rather stale... 😆

@SimonCropp SimonCropp merged commit 11bd16c into Humanizr:main Feb 15, 2024
3 checks passed
@SimonCropp
Copy link
Collaborator

@louis-z thanks. merged

@louis-z louis-z deleted the issue-958 branch February 19, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Humanize(LetterCasing.Sentence) removes a comma
2 participants