node should be a package dependency

[m-roll]

Description and Context

When running npm update -g @hubspot/cli@next or npm update -g @hubspot/cli@latest, both npm and hs aren't discoverable via $PATH (seems binaries/symlinks get removed), if this is the only global package installed. This does not seem to happen when running npm update @hubspot/cli.

Steps to reproduce

1. Run npm update -g @hubspot/cli@latest
2. npm will not be found by shell.

I believe the issue is that node needs to be a dependency of the CLI. When updating, it uses package.json to update the tree, sees that node isn't required, and then removes the cli. I think this only happens when all user packages do not have node as a dependency, it just so happens this is the only global user package I have.

Expected behavior

npm and hs remain in path

Screenshots

Who to Notify

@anthmatic

[miketalley]

Hey @m-roll thanks for posting this! I'm curious if this has to do with using npm instead of yarn for installing/updating the CLI. Have you tried using yarn global add @hubspot/cli@next?

[gcorne]

I think this is an npm bug that was fixed. See npm/cli#2736

[m-roll]

For some context, this issue (npm/cli#2014 (comment)) seems to indicate that this is not a bug but I think that comment is outdated/incorrect. Thanks for linking that issue.

@miketalley Perhaps that is the case, although I would think that npm would work just as well with package.json. If yarn is required we should call that out in the readme, since we currently recommend installing via npm. Seems like this isn't an issue if this is due to a bug though.

Edit: I'm using npm version 8.1.4 which is allegedly after this fix? Still seeing this behavior 🤔

[miketalley]

Thanks for the reference @gcorne. I'm going to close this out. @m-roll be sure to comment if you are still seeing any issues.