Refactor: fail fast

Author: tshemsedinov

JavaScript/1-sync-try.js

@@ -3,9 +3,8 @@
 const sum = (a, b) => {
   if (typeof a === 'number' && typeof b === 'number') {
     return a + b;
-  } else {
-    throw new Error('a and b should be numbers');
   }
+  throw new Error('a and b should be numbers');
 };
 
 try {

JavaScript/2-sync-tuple.js

@@ -3,9 +3,8 @@
 const sum = (a, b) => {
   if (typeof a === 'number' && typeof b === 'number') {
     return [null, a + b];
-  } else {
-    return [new Error('a and b should be numbers')];
   }
+  return [new Error('a and b should be numbers')];
 };
 
 console.log(sum(2, 3));

JavaScript/4-uncaught.js

@@ -8,11 +8,9 @@ process.on('uncaughtException', (err) => {
 const sum = (a, b) => {
   if (typeof a === 'number' && typeof b === 'number') {
     return a + b;
-  } else {
-    throw new Error('a and b should be numbers');
   }
+  throw new Error('a and b should be numbers');
 };
 
 console.log(sum(2, 3));
-
 console.log(sum(7, 'A'));

JavaScript/6-async-await.js

@@ -3,9 +3,8 @@
 const sum = async (a, b) => {
   if (typeof a === 'number' && typeof b === 'number') {
     return a + b;
-  } else {
-    throw new Error('a and b should be numbers');
   }
+  throw new Error('a and b should be numbers');
 };
 
 (async () => {