Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should warnings be fixed? #61

Open
vasily-kirichenko opened this issue Jul 7, 2017 · 1 comment
Open

Should warnings be fixed? #61

vasily-kirichenko opened this issue Jul 7, 2017 · 1 comment

Comments

@vasily-kirichenko
Copy link
Contributor

There are a number of bugs (or features?) in the codebase, like this one:

https://github.com/Horusiath/Akkling/blob/master/src/Akkling/ActorRefs.fs#L28-L41

image

Is it worth to make a PR with fixes, or you are aware of them and the code is just WIP?

@Horusiath
Copy link
Owner

Horusiath commented Jul 8, 2017

In general, we could attach some fslint rules and start to treat warnings as errors.

In this specific case I think, we should probably drop AskResult<> at all. It's always associated with bind over async computation. AFAIK most of the users expect that ask should just return object of an expected type on success, or throw an exception otherwise.

But this would come with another problem, because while try/with works well in actorOf given behaviors, actor { ... } computation expression fails to tail rec that actor (due to lack of trampolines, see #54).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants