Skip to content

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Mar 23, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label Mar 23, 2024
@chenrui333
Copy link
Member

maybe also good to file an upstream issue and PR as well?

@cho-m
Copy link
Member Author

cho-m commented Apr 11, 2024

maybe also good to file an upstream issue and PR as well?

Looks like the Alpine maintainer handled this (i.e. arxanas/git-branchless#1284, arxanas/git-branchless#1285)

Can see if commit works as patch. Otherwise, can just reference issue/PR.

Signed-off-by: Michael Cho <michael@michaelcho.dev>
@cho-m cho-m force-pushed the git-branchless-git2 branch from b29f497 to 387dc92 Compare April 11, 2024 14:43
@cho-m cho-m changed the title git-branchless: adjust git2 dependency to avoid deprecation git-branchless: backport support for libgit2 1.7 Apr 11, 2024
@cho-m cho-m added the ready to merge PR can be merged once CI is green label Apr 11, 2024
@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Apr 11, 2024
@BrewTestBot BrewTestBot enabled auto-merge April 11, 2024 20:54
@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 11, 2024
Merged via the queue into master with commit b1cbfca Apr 11, 2024
@BrewTestBot BrewTestBot deleted the git-branchless-git2 branch April 11, 2024 21:02
@github-actions github-actions bot added the outdated PR was locked due to age label May 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants