Skip to content

libgit2@1.6: deprecate, libgit2@1.5: remove head and livecheck #166949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 12, 2024
Merged

libgit2@1.6: deprecate, libgit2@1.5: remove head and livecheck #166949

merged 4 commits into from
Apr 12, 2024

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Mar 22, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Need to figure out dependents:

@cho-m cho-m added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Mar 22, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Mar 22, 2024
@chenrui333 chenrui333 enabled auto-merge March 22, 2024 23:40
@chenrui333
Copy link
Member

chenrui333 commented Mar 22, 2024

image

@chenrui333 chenrui333 disabled auto-merge March 22, 2024 23:41
@cho-m cho-m mentioned this pull request Mar 23, 2024
Merged
6 tasks
@cho-m cho-m force-pushed the libgit2@1.5-1.6-changes branch from 65a6efc to ac9cdea Compare March 23, 2024 14:26
@cho-m cho-m added the blocked label Mar 23, 2024
cho-m added 4 commits April 11, 2024 17:19
@cho-m
libgit2@1.5: remove head and livecheck
8e50cb5 
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@cho-m
libgit2@1.6: deprecate
dc514cf 
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@cho-m
versioned_head_spec_allowlist: remove libgit2@1.5 and libgit2@1.6
e8f36cf 
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@cho-m
cargo-edit: deprecate
7ab6f82 
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@cho-m cho-m force-pushed the libgit2@1.5-1.6-changes branch from ac9cdea to 7ab6f82 Compare April 11, 2024 21:21
@cho-m cho-m added ready to merge PR can be merged once CI is green and removed automerge-skip `brew pr-automerge` will skip this pull request blocked labels Apr 11, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 12, 2024
Merged via the queue into master with commit 965aa13 Apr 12, 2024
@BrewTestBot BrewTestBot deleted the libgit2@1.5-1.6-changes branch April 12, 2024 18:15
@github-actions github-actions bot added the outdated PR was locked due to age label May 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

@branchvincent branchvincent branchvincent approved these changes

Assignees

No one assigned

Labels

CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. outdated PR was locked due to age ready to merge PR can be merged once CI is green

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cho-m @chenrui333 @SMillerDev @branchvincent @BrewTestBot